From mboxrd@z Thu Jan 1 00:00:00 1970 From: Helge Deller Subject: Re: [PATCH] ide-cd: fix kernel crash on hppa regression Date: Sat, 25 Apr 2009 13:19:08 +0200 Message-ID: <49F2F1AC.7090900@gmx.de> References: <49E6638B.8090700@gmx.de> <20090422061253.GB22451@liondog.tnic> <49EF8868.4050308@gmx.de> <200904232334.55231.bzolnier@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: petkovbb@gmail.com, Linus , Borislav Petkov , Kyle McMartin , linux-parisc , "Rafael J. Wysocki" To: Bartlomiej Zolnierkiewicz Return-path: In-Reply-To: <200904232334.55231.bzolnier@gmail.com> List-ID: List-Id: linux-parisc.vger.kernel.org Bartlomiej Zolnierkiewicz wrote: > On Wednesday 22 April 2009 23:13:12 Helge Deller wrote: >> Borislav Petkov wrote: >>> On Fri, Apr 17, 2009 at 09:15:27AM +0200, Helge Deller wrote: >>> [..] >>>>>> BTW, even with my patch ATAPI CDROM accesses don't work with the current kernel... >>>>> What do you mean by that, please elaborate? >>>> I meant: >>>> a) Without my patch the kernel did crash (see backtrace in original mail) >>>> b) with my patch the kernel booted to login prompt, but I got those messages on the console: >>>> hda: command error: status=0x51 { DriveReady SeekComplete Error } >>>> hda: command error: error=0x54 <3>{ AbortedCommand LastFailedSense=0x05 } >>>> ide: failed opcode was: unknown >>>> Nevertheless, mounting a cdrom in the drive didn't suceeded with same/similiar messages, but >>>> this could even be because of the parisc superio driver... >>> Is it possible to isolate it and test without the superio driver? >> No, since the superio controller provides the IDE ports. > > Is 2.6.29 working ok? What about 2.6.30-rc1 + your fix? * 2.6.29 works perfectly. * 2.6.30-rc3 (includes my patch) does work as well, but I see quite often those messages: hda: command error: status=0x51 { DriveReady SeekComplete Error } hda: command error: error=0x54 <3>{ AbortedCommand LastFailedSense=0x05 } ide: failed opcode was: unknown * drivers/parisc/superio.c had no (important) changes between 2.6.29 and 2.6.30-rcX * to me it seems your changes to drivers/ide/ns87415.c have raised those problems. * maybe you added some inb() in the new paths, which should call superio_ide_inb() (see to of ns87415.c) instead? * it seems the problem happens more often in some fault-paths, for example when reading a faulty disc in the cdrom drive Best regards, Helge