From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Helge Deller <deller@gmx.de>, Craig Gallek <kraig@google.com>,
Alexei Starovoitov <ast@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org
Cc: linux-parisc@vger.kernel.org
Subject: Re: [PATCH] soreuseport: add compat case for setsockopt SO_ATTACH_REUSEPORT_CBPF
Date: Fri, 3 Jun 2016 21:11:24 +0300 [thread overview]
Message-ID: <4cec14e5-2950-be26-1ffa-8d604bdb2fb5@cogentembedded.com> (raw)
In-Reply-To: <20160603171805.GA3664@ls3530.box>
Hello.
On 06/03/2016 08:18 PM, Helge Deller wrote:
> Commit 538950a ("soreuseport: setsockopt SO_ATTACH_REUSEPORT_[CE]BPF")
At least 12 digits must be specified for SHA1. checkpatch.pl should've
caught this.
> missed to add the compat case for the SO_ATTACH_REUSEPORT_CBPF
> setsockoption() option.
>
> Since both SO_ATTACH_FILTER and SO_ATTACH_REUSEPORT_CBPF use a struct
> sock_fprog let's combine the handling of both.
>
> Signed-off-by: Helge Deller <deller@gmx.de>
>
> diff --git a/net/compat.c b/net/compat.c
> index 5cfd26a..7e2aac9 100644
> --- a/net/compat.c
> +++ b/net/compat.c
> @@ -309,7 +309,7 @@ void scm_detach_fds_compat(struct msghdr *kmsg, struct scm_cookie *scm)
> __scm_destroy(scm);
> }
>
> -static int do_set_attach_filter(struct socket *sock, int level, int optname,
> +static int do_sockopt_fix_sock_fprog(struct socket *sock, int level, int optname,
> char __user *optval, unsigned int optlen)
You need to realign this line now.
[...]
WBR, Sergei
next prev parent reply other threads:[~2016-06-03 18:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-03 17:18 [PATCH] soreuseport: add compat case for setsockopt SO_ATTACH_REUSEPORT_CBPF Helge Deller
2016-06-03 18:11 ` Sergei Shtylyov [this message]
2016-06-03 21:09 ` Helge Deller
-- strict thread matches above, loose matches on Subject: below --
2016-06-03 21:33 Craig Gallek
2016-06-03 21:40 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4cec14e5-2950-be26-1ffa-8d604bdb2fb5@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=ast@kernel.org \
--cc=davem@davemloft.net \
--cc=deller@gmx.de \
--cc=kraig@google.com \
--cc=linux-parisc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox