From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Cree Subject: Re: [PATCH 00/11] rcu: Add missing RCU idle APIs on idle loop v2 Date: Sat, 25 Aug 2012 14:10:17 +1200 Message-ID: <50383409.7090207@orcon.net.nz> References: <1345733915-20040-1-git-send-email-fweisbec@gmail.com> <20120824212647.GU2472@linux.vnet.ibm.com> <1345857554.4840.43.camel@deadeye.wl.decadent.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: paulmck@linux.vnet.ibm.com, Frederic Weisbecker , LKML , Chris Zankel , "3.2.x.." , Chen Liqin , Lennox Wu , "James E.J. Bottomley" , Helge Deller , Parisc , David Howells , Koichi Yasutake , Geert Uytterhoeven , m68k , Hirokazu Takata , Yoshinori Sato , Mikael Starvik , Jesper Nilsson , Cris , Richard Henderson , Ivan Kokshaysky , Matt Turner , alpha Return-path: In-Reply-To: <1345857554.4840.43.camel@deadeye.wl.decadent.org.uk> List-ID: List-Id: linux-parisc.vger.kernel.org On 25/08/12 13:19, Ben Hutchings wrote: > On Fri, 2012-08-24 at 14:26 -0700, Paul E. McKenney wrote: >> On Thu, Aug 23, 2012 at 04:58:24PM +0200, Frederic Weisbecker wrote: >>> Hi, >>> >>> Changes since v1: >>> >>> - Fixed preempt handling in alpha idle loop >>> - added ack from Geert >>> - fixed stable email address, sorry :-/ >>> >>> This time I built tested everywhere but: h8300 (compiler internal error), >>> and mn10300, parisc, score (cross compilers not available in >>> ftp://ftp.kernel.org/pub/tools/crosstool/files/bin/x86_64/4.6.3/) >>> >>> For testing, you can pull from: >>> >>> git://github.com/fweisbec/linux-dynticks.git >>> rcu/idle-fix-v2 >>> >>> Thanks. >> >> I have queued these on -rcu branch rcu/idle: >> >> git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git >> >> This problem has been in place since 3.3, so it is hard to argue that >> it is a regression for this merge window. I have therefore queued it >> for 3.7. > > I don't follow that; I would expect any serious bug fix (serious enough > for a stable update) to be acceptable for 3.6 at this point. > > If the regression occurred in 3.3, then the cc lines should be something > like: > > Cc: # 3.3+ > > and not the current: > > Cc: 3.2.x.. The Alpha patches fix an even earlier regression resulting in RCU CPU stalls on an SMP kernel built for generic Alpha (which includes the current Debian 3.2-alpha-smp kernel) and renders the kernel pretty much unuseable. I've only tested the two alpha patches together but maybe just the first patch (1/11 alpha: Fix preemption handling in idle loop) might be needed to fix the problem in 3.2. I'll test and let you know. Cheers Michael.