From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chen Gang Subject: [PATCH] arch: parisc: kernel: using strlcpy() instead of strcpy() Date: Thu, 30 May 2013 09:18:43 +0800 Message-ID: <51A6A8F3.2030200@asianux.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Cc: Greg KH , Parisc List , "linux-kernel@vger.kernel.org" , Linux-Arch To: "James E.J. Bottomley" , Helge Deller , udknight@gmail.com Return-path: List-ID: List-Id: linux-parisc.vger.kernel.org 'boot_args' is an input args, and 'boot_command_line' has a fix length. So need use strlcpy() instead of strcpy() to avoid memory overflow. Signed-off-by: Chen Gang --- arch/parisc/kernel/setup.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/arch/parisc/kernel/setup.c b/arch/parisc/kernel/setup.c index 60c1ae6..7349a3f 100644 --- a/arch/parisc/kernel/setup.c +++ b/arch/parisc/kernel/setup.c @@ -69,7 +69,8 @@ void __init setup_cmdline(char **cmdline_p) /* called from hpux boot loader */ boot_command_line[0] = '\0'; } else { - strcpy(boot_command_line, (char *)__va(boot_args[1])); + strlcpy(boot_command_line, (char *)__va(boot_args[1]), + COMMAND_LINE_SIZE); #ifdef CONFIG_BLK_DEV_INITRD if (boot_args[2] != 0) /* did palo pass us a ramdisk? */ -- 1.7.7.6