linux-parisc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Helge Deller <deller@gmx.de>
To: Jeroen Roovers <jer@gentoo.org>
Cc: linux-parisc@vger.kernel.org
Subject: Re: fanotify_mark()
Date: Mon, 26 Aug 2013 23:27:39 +0200	[thread overview]
Message-ID: <521BC84B.4090602@gmx.de> (raw)
In-Reply-To: <20130826014657.05f4c466@marga.jer-c2.orkz.net>

On 08/26/2013 01:46 AM, Jeroen Roovers wrote:
> On Wed, 14 Aug 2013 00:54:00 +0200
> Jeroen Roovers <jer@gentoo.org> wrote:
> 
>> On Tue, 13 Aug 2013 23:29:42 +0200
>> Helge Deller <deller@gmx.de> wrote:
>>
>>>> [1] https://bugs.gentoo.org/show_bug.cgi?id=480268
>>>
>>> In the Linux kernel we use the compat layer for 32bit syscalls on
>>> 64bit kernel: arch/parisc/kernel/syscall_table.S:
>>> ENTRY_COMP(fanotify_mark) which means we call (with 32bit userspace
>>> on 64bit kernel):
>>> fs/notify/fanotify/fanotify_user.c:COMPAT_SYSCALL_DEFINE6(fanotify_mark,
>>> int, fanotify_fd, unsigned int, flags, __u32, mask0, __u32, mask1,
>>> int, dfd, const char  __user *, pathname) which has 6 parameters.
>>>
>>> So, I assume you need one more "i" in this line here (change i:iiiis
>>> -> i:iiiiis {to 5 i's}):
>>
>> I tried that too with a similarly bad result
> 
> After the 5 i patch =and= recompiling fatrace, fanotify_mark() now works
> properly.

Great!
I didn't checked, but will the "5 i" work on 32bit too? Don't think so...

> Which brings me no closer to systemd support on HPPA, I'm
> afraid, but at least systemd now installs properly. I'm working on
> writing up another e-mail about the next hurdle[1] systemd presents us.
> [1] Sneak preview: https://bugs.gentoo.org/show_bug.cgi?id=482214

Did you already filed this signal-problem upstream as suggested in comment #3 (https://bugs.gentoo.org/show_bug.cgi?id=482214#c3)?

Helge


  reply	other threads:[~2013-08-26 21:27 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-13 13:49 fanotify_mark() Jeroen Roovers
2013-08-13 21:29 ` fanotify_mark() Helge Deller
2013-08-13 22:54   ` fanotify_mark() Jeroen Roovers
2013-08-25 23:46     ` fanotify_mark() Jeroen Roovers
2013-08-26 21:27       ` Helge Deller [this message]
2013-08-26 22:37         ` fanotify_mark() John David Anglin
2013-08-27 14:46           ` systemd real-time signals choices clash with Linux/PARISC available SIGRT range, WAS: fanotify_mark() Jeroen Roovers
2013-08-27 15:26             ` John David Anglin
2013-08-27 15:52               ` John David Anglin
2013-09-18 18:40               ` Helge Deller
2013-09-18 18:58                 ` John David Anglin
2013-08-27 14:31         ` fanotify_mark() Jeroen Roovers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=521BC84B.4090602@gmx.de \
    --to=deller@gmx.de \
    --cc=jer@gentoo.org \
    --cc=linux-parisc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).