From: Helge Deller <deller@gmx.de>
To: John David Anglin <dave.anglin@bell.net>,
linux-parisc@vger.kernel.org,
James Bottomley <James.Bottomley@HansenPartnership.com>
Subject: Re: [PATCH] parisc: check hardcoded value of SHMLBA against value reported by firmware
Date: Tue, 29 Oct 2013 22:11:29 +0100 [thread overview]
Message-ID: <52702481.9050308@gmx.de> (raw)
In-Reply-To: <BLU0-SMTP812DBA341716B80C3A40A597090@phx.gbl>
On 10/29/2013 10:10 PM, John David Anglin wrote:
> I seem to recall the aliasing boundary value returned by my rp3440 is "unknown".
Even better, then it would be interesting to see what this patch reports on
your machine....
>
> On 10/29/2013 5:05 PM, Helge Deller wrote:
>> Our value of SHMLBA is hardcoded to 4MB on parisc due to aliasing restrictions
>> of the platform. The firmware function PDC_CACHE does return the machine
>> dependend value of this aliasing requirement.
>> So, if there is a difference between those two - which we don't expect - let's
>> report it at least.
>>
>> Signed-off-by: Helge Deller <deller@gmx.de>
>>
>> diff --git a/arch/parisc/kernel/cache.c b/arch/parisc/kernel/cache.c
>> index c035673..3523e20 100644
>> --- a/arch/parisc/kernel/cache.c
>> +++ b/arch/parisc/kernel/cache.c
>> @@ -142,6 +142,15 @@ parisc_cache_init(void)
>> if (pdc_cache_info(&cache_info) < 0)
>> panic("parisc_cache_init: pdc_cache_info failed");
>> + /*
>> + * The alias field returned by PDC_CACHE specifies the aliasing
>> + * boundaries for virtual addresses. So, let's verify if our hardcoded
>> + * value of SHMLBA (4 MB) is correct for this machine.
>> + */
>> + if ((4096UL << (cache_info.dc_conf.cc_alias-1)) != SHMLBA)
>> + pr_warn("WARNING: PDC_CACHE returns aliasing of %lu kB.\n",
>> + (4UL << (cache_info.dc_conf.cc_alias-1)));
>> +
>> #if 0
>> printk("ic_size %lx dc_size %lx it_size %lx\n",
>> cache_info.ic_size,
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-parisc" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>>
>
>
next prev parent reply other threads:[~2013-10-29 21:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-29 21:05 [PATCH] parisc: check hardcoded value of SHMLBA against value reported by firmware Helge Deller
2013-10-29 21:10 ` John David Anglin
2013-10-29 21:11 ` Helge Deller [this message]
2013-10-29 21:26 ` James Bottomley
2013-10-29 21:28 ` Helge Deller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52702481.9050308@gmx.de \
--to=deller@gmx.de \
--cc=James.Bottomley@HansenPartnership.com \
--cc=dave.anglin@bell.net \
--cc=linux-parisc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).