From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chen Gang Subject: Re: [PATCH v3] arch: Kconfig: Let all architectures set endian explicitly Date: Fri, 15 Aug 2014 06:22:35 +0800 Message-ID: <53ED36AB.8020703@gmail.com> References: <53ECE9DD.80004@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: Vineet Gupta , Arnd Bergmann , "akpm@linux-foundation.org" , "rth@twiddle.net" , "ink@jurassic.park.msu.ru" , "mattst88@gmail.com" , Geert Uytterhoeven , Jean Delvare , "linux@arm.linux.org.uk" , "catalin.marinas@arm.com" , "will.deacon@arm.com" , "hskinnemoen@gmail.com" , "egtvedt@samfundet.no" , "realmz6@gmail.com" , "msalter@redhat.com" , "a-jacquiot@ti.com" , "starvik@axis.com" , "jesper.n To: Lennox Wu Return-path: In-Reply-To: Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips List-subscribe: List-owner: List-post: List-archive: On 08/15/2014 02:27 AM, Lennox Wu wrote: > I don't think it's necessary, what's the benfit? > > 2014-08-15 2:21 GMT+08:00 Vineet Gupta : > >> On Thursday 14 August 2014 09:55 AM, Chen Gang wrote: [...] >>> diff --git a/arch/arc/Kconfig b/arch/arc/Kconfig >>> index 9596b0a..e939abd 100644 >>> --- a/arch/arc/Kconfig >>> +++ b/arch/arc/Kconfig >>> @@ -35,6 +35,7 @@ config ARC >>> select OF_EARLY_FLATTREE >>> select PERF_USE_VMALLOC >>> select HAVE_DEBUG_STACKOVERFLOW >>> + select CPU_LITTLE_ENDIAN if !CPU_BIG_ENDIAN >> >> It is not clear what exactly are you trying to fix. What doesn't work w/o >> this >> patch ! >> For many individual modules may need check CPU_LITTLE_ENDIAN or CPU_BIG_ENDIAN, which is an architecture's attribute. Or they have to list many architectures which they support, which they don't support. And still, it is not precise. For architecture API, endian is a main architecture's attribute which may be used by outside, so every architecture need let outside know about it, explicitly. Thanks. -- Chen Gang Open share and attitude like air water and life which God blessed