From mboxrd@z Thu Jan 1 00:00:00 1970 From: Helge Deller Subject: Re: [PATCH 1/3] module_arch_freeing_init(): new hook for archs before module->module_init freed. Date: Tue, 13 Jan 2015 22:11:34 +0100 Message-ID: <54B58A06.5000800@gmx.de> References: <1420678687-30548-1-git-send-email-rusty@rustcorp.com.au> <1420678687-30548-2-git-send-email-rusty@rustcorp.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Cc: Chris Metcalf , Haavard Skinnemoen , Hans-Christian Egtvedt , Tony Luck , Fenghua Yu , "James E.J. Bottomley" , Martin Schwidefsky , Heiko Carstens , linux-ia64@vger.kernel.org, linux-parisc@vger.kernel.org, linux-s390@vger.kernel.org To: Rusty Russell , linux-kernel@vger.kernel.org Return-path: In-Reply-To: <1420678687-30548-2-git-send-email-rusty@rustcorp.com.au> List-ID: List-Id: linux-parisc.vger.kernel.org On 08.01.2015 01:58, Rusty Russell wrote: > Archs have been abusing module_free() to clean up their arch-specific > allocations. Since module_free() is also (ab)used by BPF and trace code, > let's keep it to simple allocations, and provide a hook called before > that. > > This means that avr32, ia64, parisc and s390 no longer need to implement > their own module_free() at all. avr32 doesn't need module_finalize() > either. > > Signed-off-by: Rusty Russell > Cc: Chris Metcalf > Cc: Haavard Skinnemoen > Cc: Hans-Christian Egtvedt > Cc: Tony Luck > Cc: Fenghua Yu > Cc: "James E.J. Bottomley" > Cc: Helge Deller > Cc: Martin Schwidefsky > Cc: Heiko Carstens > Cc: linux-kernel@vger.kernel.org > Cc: linux-ia64@vger.kernel.org > Cc: linux-parisc@vger.kernel.org > Cc: linux-s390@vger.kernel.org > --- > arch/avr32/kernel/module.c | 13 +------------ > arch/ia64/kernel/module.c | 6 ++---- > arch/parisc/kernel/module.c | 6 +----- > arch/s390/kernel/module.c | 10 +++------- > arch/tile/kernel/module.c | 2 +- > include/linux/moduleloader.h | 2 ++ > kernel/module.c | 7 +++++++ > 7 files changed, 17 insertions(+), 29 deletions(-) I successfully tested it on the parisc arch. Acked-by: Helge Deller Thanks! Helge