From: Andreas Ziegler <andreas.ziegler@fau.de>
To: Helge Deller <deller@gmx.de>
Cc: linux-parisc@vger.kernel.org,
Valentin Rothberg <valentinrothberg@gmail.com>,
Paul Bolle <pebolle@tiscali.nl>,
linux-kernel <linux-kernel@vger.kernel.org>,
John David Anglin <dave.anglin@bell.net>
Subject: Re: parisc: adjust L1_CACHE_BYTES to 128 bytes on PA8800 and PA8900 CPUs
Date: Thu, 03 Sep 2015 11:23:55 +0200 [thread overview]
Message-ID: <55E811AB.6070002@fau.de> (raw)
Hi Helge,
today's linux-next tree (next-20150903) contains commit 20f924902ff6
("parisc: adjust L1_CACHE_BYTES to 128 bytes on PA8800 and PA8900 CPUs")
which you authored.
I noticed it because we[0] are running a daily analysis on all commits
in linux-next as part of our research and our tools reported it.
In the patch, you create the following #if defined() structure in
arch/parisc/include/asm/cache.h (lines 16 and following):
#if defined(CONFIG_PA8X00)
...
#elif defined(CONFIG_PA20)
...
#else
...
#endif
In Kconfig, CONFIG_PA20 is defined as the following
(arch/parisc/Kconfig, line 163):
config PA20
def_bool y
depends on PA8X00
This means that CONFIG_PA20 can and will only be enabled if
CONFIG_PA8X00 has already been enabled, which means that the contents of
the "#elif defined(CONFIG_PA20)" block can never be reached: its
condition is only evaluated if CONFIG_PA8X00 is disabled, but then
CONFIG_PA20 can never be enabled either.
Best regards,
Andreas
[0] https://cados.cs.fau.de
next reply other threads:[~2015-09-03 9:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-03 9:23 Andreas Ziegler [this message]
2015-09-03 18:45 ` parisc: adjust L1_CACHE_BYTES to 128 bytes on PA8800 and PA8900 CPUs Helge Deller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E811AB.6070002@fau.de \
--to=andreas.ziegler@fau.de \
--cc=dave.anglin@bell.net \
--cc=deller@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=pebolle@tiscali.nl \
--cc=valentinrothberg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).