From: Helge Deller <deller@gmx.de>
To: Guenter Roeck <linux@roeck-us.net>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Richard Henderson <rth@twiddle.net>,
Ralf Baechle <ralf@linux-mips.org>,
Chris Zankel <chris@zankel.net>,
linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mips@linux-mips.org, linux-parisc@vger.kernel.org,
Chen Gang <gang.chen.5i5j@gmail.com>,
Minchan Kim <minchan@kernel.org>
Subject: Re: [PATCH] mm: Remove duplicate definitions of MADV_FREE
Date: Mon, 18 Jan 2016 09:23:49 +0100 [thread overview]
Message-ID: <569CA115.3010305@gmx.de> (raw)
In-Reply-To: <1453087746-4658-1-git-send-email-linux@roeck-us.net>
On 18.01.2016 04:29, Guenter Roeck wrote:
> Commits 21f55b018ba5 ("arch/*/include/uapi/asm/mman.h: : let MADV_FREE
> have same value for all architectures") and ef58978f1eaa ("mm: define
> MADV_FREE for some arches") both defined MADV_FREE, but did not use the
> same values. This results in build errors such as
>
> ./arch/alpha/include/uapi/asm/mman.h:53:0: error: "MADV_FREE" redefined
> ./arch/alpha/include/uapi/asm/mman.h:50:0: note:
> this is the location of the previous definition
>
> for the affected architectures.
>
> Fixes: 21f55b018ba5 ("arch/*/include/uapi/asm/mman.h: : let MADV_FREE have same value for all architectures")
> Fixes: ef58978f1eaa ("mm: define MADV_FREE for some arches")
> Cc: Chen Gang <gang.chen.5i5j@gmail.com>
> Cc: Minchan Kim <minchan@kernel.org>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
On parisc both definitions of MADV_FREE are 8, so I do not face the compiler error.
Nevertheless it should be cleaned up.
Acked-by: Helge Deller <deller@gmx.de> (for parisc)
Thanks!
Helge
> ---
> arch/alpha/include/uapi/asm/mman.h | 1 -
> arch/mips/include/uapi/asm/mman.h | 1 -
> arch/parisc/include/uapi/asm/mman.h | 1 -
> arch/xtensa/include/uapi/asm/mman.h | 1 -
> 4 files changed, 4 deletions(-)
>
> diff --git a/arch/parisc/include/uapi/asm/mman.h b/arch/parisc/include/uapi/asm/mman.h
> index cf830d465f75..f3db7d8eb0c2 100644
> --- a/arch/parisc/include/uapi/asm/mman.h
> +++ b/arch/parisc/include/uapi/asm/mman.h
> @@ -43,7 +43,6 @@
> #define MADV_SPACEAVAIL 5 /* insure that resources are reserved */
> #define MADV_VPS_PURGE 6 /* Purge pages from VM page cache */
> #define MADV_VPS_INHERIT 7 /* Inherit parents page size */
> -#define MADV_FREE 8 /* free pages only if memory pressure */
>
> /* common/generic parameters */
> #define MADV_FREE 8 /* free pages only if memory pressure */
prev parent reply other threads:[~2016-01-18 8:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-18 3:29 [PATCH] mm: Remove duplicate definitions of MADV_FREE Guenter Roeck
2016-01-18 8:23 ` Helge Deller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569CA115.3010305@gmx.de \
--to=deller@gmx.de \
--cc=akpm@linux-foundation.org \
--cc=chris@zankel.net \
--cc=gang.chen.5i5j@gmail.com \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=minchan@kernel.org \
--cc=ralf@linux-mips.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).