* [PATCH] parisc: Use LINUX_GATEWAY_ADDR define instead of hardcoded value value
@ 2016-10-29 21:52 Helge Deller
2016-10-30 10:23 ` Rolf Eike Beer
0 siblings, 1 reply; 5+ messages in thread
From: Helge Deller @ 2016-10-29 21:52 UTC (permalink / raw)
To: linux-parisc, James Bottomley, John David Anglin
LINUX_GATEWAY_ADDR is defined in unistd.h. Let's use it.
Signed-off-by: Helge Deller <deller@gmx.de>
diff --git a/arch/parisc/kernel/syscall.S b/arch/parisc/kernel/syscall.S
index d03422e..d3407cf 100644
--- a/arch/parisc/kernel/syscall.S
+++ b/arch/parisc/kernel/syscall.S
@@ -100,7 +100,7 @@ set_thread_pointer:
.endr
/* This address must remain fixed at 0x100 for glibc's syscalls to work */
- .align 256
+ .align LINUX_GATEWAY_ADDR
linux_gateway_entry:
gate .+8, %r0 /* become privileged */
mtsp %r0,%sr4 /* get kernel space into sr4 */
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] parisc: Use LINUX_GATEWAY_ADDR define instead of hardcoded value value
2016-10-29 21:52 [PATCH] parisc: Use LINUX_GATEWAY_ADDR define instead of hardcoded value value Helge Deller
@ 2016-10-30 10:23 ` Rolf Eike Beer
2016-10-31 9:26 ` Helge Deller
0 siblings, 1 reply; 5+ messages in thread
From: Rolf Eike Beer @ 2016-10-30 10:23 UTC (permalink / raw)
To: linux-parisc
[-- Attachment #1: Type: text/plain, Size: 93 bytes --]
Helge Deller wrote:
> LINUX_GATEWAY_ADDR is defined in unistd.h. Let's use it.
value value?
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] parisc: Use LINUX_GATEWAY_ADDR define instead of hardcoded value value
2016-10-30 10:23 ` Rolf Eike Beer
@ 2016-10-31 9:26 ` Helge Deller
2016-11-01 18:25 ` Jeroen Roovers
0 siblings, 1 reply; 5+ messages in thread
From: Helge Deller @ 2016-10-31 9:26 UTC (permalink / raw)
To: Rolf Eike Beer, linux-parisc@vger.kernel.org
On 30.10.2016 11:23, Rolf Eike Beer wrote:
> Helge Deller wrote:
>
>> LINUX_GATEWAY_ADDR is defined in unistd.h. Let's use it.
>
> value value?
I do see huge value in being able to see where this value is being
used. A new developer who uses grep will find the relevant assembler
code as well.
Helge
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] parisc: Use LINUX_GATEWAY_ADDR define instead of hardcoded value value
2016-10-31 9:26 ` Helge Deller
@ 2016-11-01 18:25 ` Jeroen Roovers
2016-11-02 21:55 ` Helge Deller
0 siblings, 1 reply; 5+ messages in thread
From: Jeroen Roovers @ 2016-11-01 18:25 UTC (permalink / raw)
To: Helge Deller; +Cc: Rolf Eike Beer, linux-parisc@vger.kernel.org
On Mon, 31 Oct 2016 10:26:37 +0100
Helge Deller <deller@gmx.de> wrote:
> On 30.10.2016 11:23, Rolf Eike Beer wrote:
> > Helge Deller wrote:
> >
> >> LINUX_GATEWAY_ADDR is defined in unistd.h. Let's use it.
> >
> > value value?
>
> I do see huge value in being able to see where this value is being
> used. A new developer who uses grep will find the relevant assembler
> code as well.
Yes, but "value value"! ;-)
Regards,
jer
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] parisc: Use LINUX_GATEWAY_ADDR define instead of hardcoded value value
2016-11-01 18:25 ` Jeroen Roovers
@ 2016-11-02 21:55 ` Helge Deller
0 siblings, 0 replies; 5+ messages in thread
From: Helge Deller @ 2016-11-02 21:55 UTC (permalink / raw)
To: Jeroen Roovers; +Cc: Rolf Eike Beer, linux-parisc@vger.kernel.org
On 01.11.2016 19:25, Jeroen Roovers wrote:
> On Mon, 31 Oct 2016 10:26:37 +0100
> Helge Deller <deller@gmx.de> wrote:
>
>> On 30.10.2016 11:23, Rolf Eike Beer wrote:
>>> Helge Deller wrote:
>>>
>>>> LINUX_GATEWAY_ADDR is defined in unistd.h. Let's use it.
>>>
>>> value value?
>>
>> I do see huge value in being able to see where this value is being
>> used. A new developer who uses grep will find the relevant assembler
>> code as well.
>
> Yes, but "value value"! ;-)
Yes, I'm blind :-)
It took me quite some time (and one additional off-list reminder
from Rolf Eike) to understand that you both meant the commit title :-)
I'll fix it before I send upstream.
Thanks!
Helge
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-11-02 21:55 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-29 21:52 [PATCH] parisc: Use LINUX_GATEWAY_ADDR define instead of hardcoded value value Helge Deller
2016-10-30 10:23 ` Rolf Eike Beer
2016-10-31 9:26 ` Helge Deller
2016-11-01 18:25 ` Jeroen Roovers
2016-11-02 21:55 ` Helge Deller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).