From: Helge Deller <deller@gmx.de>
To: Jeroen Roovers <jer@gentoo.org>
Cc: Rolf Eike Beer <eike-kernel@sf-tec.de>,
"linux-parisc@vger.kernel.org" <linux-parisc@vger.kernel.org>
Subject: Re: [PATCH] parisc: Use LINUX_GATEWAY_ADDR define instead of hardcoded value value
Date: Wed, 2 Nov 2016 22:55:02 +0100 [thread overview]
Message-ID: <581A60B6.6080207@gmx.de> (raw)
In-Reply-To: <20161101192512.1cd9bb27@wim.fritz.box>
On 01.11.2016 19:25, Jeroen Roovers wrote:
> On Mon, 31 Oct 2016 10:26:37 +0100
> Helge Deller <deller@gmx.de> wrote:
>
>> On 30.10.2016 11:23, Rolf Eike Beer wrote:
>>> Helge Deller wrote:
>>>
>>>> LINUX_GATEWAY_ADDR is defined in unistd.h. Let's use it.
>>>
>>> value value?
>>
>> I do see huge value in being able to see where this value is being
>> used. A new developer who uses grep will find the relevant assembler
>> code as well.
>
> Yes, but "value value"! ;-)
Yes, I'm blind :-)
It took me quite some time (and one additional off-list reminder
from Rolf Eike) to understand that you both meant the commit title :-)
I'll fix it before I send upstream.
Thanks!
Helge
prev parent reply other threads:[~2016-11-02 21:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-29 21:52 [PATCH] parisc: Use LINUX_GATEWAY_ADDR define instead of hardcoded value value Helge Deller
2016-10-30 10:23 ` Rolf Eike Beer
2016-10-31 9:26 ` Helge Deller
2016-11-01 18:25 ` Jeroen Roovers
2016-11-02 21:55 ` Helge Deller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=581A60B6.6080207@gmx.de \
--to=deller@gmx.de \
--cc=eike-kernel@sf-tec.de \
--cc=jer@gentoo.org \
--cc=linux-parisc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).