From: Markus Elfring <Markus.Elfring@web.de>
To: Daniel Vetter <daniel.vetter@ffwll.ch>,
Kaiyuan Zhang <kaiyuanz@google.com>,
Mina Almasry <almasrymina@google.com>,
Pavel Begunkov <asml.silence@gmail.com>,
Willem de Bruijn <willemb@google.com>,
netdev@vger.kernel.org, linux-doc@vger.kernel.org,
linux-alpha@vger.kernel.org, linux-mips@vger.kernel.org,
linux-parisc@vger.kernel.org, sparclinux@vger.kernel.org,
linux-trace-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
linux-kselftest@vger.kernel.org, bpf@vger.kernel.org,
linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org
Cc: LKML <linux-kernel@vger.kernel.org>,
"Andreas Larsson" <andreas@gaisler.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"Bagas Sanjaya" <bagasdotme@gmail.com>,
"Christian König" <christian.koenig@amd.com>,
"Christoph Hellwig" <hch@infradead.org>,
"David Ahern" <dsahern@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
"David Wei" <dw@davidwei.uk>,
"Donald Hunter" <donald.hunter@gmail.com>,
"Eric Dumazet" <edumazet@google.com>,
"Harshitha Ramamurthy" <hramamurthy@google.com>,
"Helge Deller" <deller@gmx.de>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
"Ilias Apalodimas" <ilias.apalodimas@linaro.org>,
"Ivan Kokshaysky" <ink@jurassic.park.msu.ru>,
"Jakub Kicinski" <kuba@kernel.org>,
"James E. J. Bottomley" <James.Bottomley@HansenPartnership.com>,
"Jason Gunthorpe" <jgg@ziepe.ca>,
"Jeroen de Borst" <jeroendb@google.com>,
"Jesper Dangaard Brouer" <hawk@kernel.org>,
"Jonathan Corbet" <corbet@lwn.net>,
"Masami Hiramatsu" <mhiramat@kernel.org>,
"Mathieu Desnoyers" <mathieu.desnoyers@efficios.com>,
"Matt Turner" <mattst88@gmail.com>,
"Nikolay Aleksandrov" <razor@blackwall.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Praveen Kaligineedi" <pkaligineedi@google.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Shailend Chand" <shailend@google.com>,
"Shakeel Butt" <shakeel.butt@linux.dev>,
"Shuah Khan" <shuah@kernel.org>,
"Steffen Klassert" <steffen.klassert@secunet.com>,
"Steven Rostedt" <rostedt@goodmis.org>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"Taehee Yoo" <ap420073@gmail.com>,
"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
"Willem de Bruijn" <willemdebruijn.kernel@gmail.com>,
"Yunsheng Lin" <linyunsheng@huawei.com>
Subject: Re: [PATCH net-next v17 03/14] netdev: support binding dma-buf to netdevice
Date: Tue, 30 Jul 2024 10:37:56 +0200 [thread overview]
Message-ID: <5d3c74da-7d44-4b88-8961-60f21f84f0ac@web.de> (raw)
In-Reply-To: <20240730022623.98909-4-almasrymina@google.com>
…
> +++ b/include/net/devmem.h
> @@ -0,0 +1,115 @@
…
> +#ifndef _NET_DEVMEM_H
> +#define _NET_DEVMEM_H
…
I suggest to omit leading underscores from such identifiers.
https://wiki.sei.cmu.edu/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier
Regards,
Markus
next prev parent reply other threads:[~2024-07-30 8:39 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-30 2:26 [PATCH net-next v17 00/14] Device Memory TCP Mina Almasry
2024-07-30 2:26 ` [PATCH net-next v17 01/14] netdev: add netdev_rx_queue_restart() Mina Almasry
2024-07-30 8:14 ` Xuan Zhuo
2024-07-31 21:19 ` Mina Almasry
2024-07-30 2:26 ` [PATCH net-next v17 02/14] net: netdev netlink api to bind dma-buf to a net device Mina Almasry
2024-07-30 2:26 ` [PATCH net-next v17 03/14] netdev: support binding dma-buf to netdevice Mina Almasry
2024-07-30 8:37 ` Markus Elfring [this message]
2024-08-05 16:33 ` Mina Almasry
2024-08-06 7:03 ` Markus Elfring
2024-08-06 12:39 ` Willem de Bruijn
2024-08-09 7:56 ` Simon Horman
2024-07-30 2:26 ` [PATCH net-next v17 04/14] netdev: netdevice devmem allocator Mina Almasry
2024-07-30 2:26 ` [PATCH net-next v17 05/14] page_pool: move dmaddr helpers to .c file Mina Almasry
2024-07-30 2:26 ` [PATCH net-next v17 06/14] page_pool: devmem support Mina Almasry
2024-07-30 2:26 ` [PATCH net-next v17 07/14] memory-provider: dmabuf devmem memory provider Mina Almasry
2024-07-30 2:26 ` [PATCH net-next v17 08/14] net: support non paged skb frags Mina Almasry
2024-07-30 2:26 ` [PATCH net-next v17 09/14] net: add support for skbs with unreadable frags Mina Almasry
2024-07-30 2:26 ` [PATCH net-next v17 10/14] tcp: RX path for devmem TCP Mina Almasry
2024-07-30 2:26 ` [PATCH net-next v17 11/14] net: add SO_DEVMEM_DONTNEED setsockopt to release RX frags Mina Almasry
2024-07-30 2:26 ` [PATCH net-next v17 12/14] net: add devmem TCP documentation Mina Almasry
2024-07-30 2:26 ` [PATCH net-next v17 13/14] selftests: add ncdevmem, netcat for devmem TCP Mina Almasry
2024-07-30 2:26 ` [PATCH net-next v17 14/14] netdev: add dmabuf introspection Mina Almasry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d3c74da-7d44-4b88-8961-60f21f84f0ac@web.de \
--to=markus.elfring@web.de \
--cc=James.Bottomley@HansenPartnership.com \
--cc=almasrymina@google.com \
--cc=andreas@gaisler.com \
--cc=ap420073@gmail.com \
--cc=arnd@arndb.de \
--cc=asml.silence@gmail.com \
--cc=bagasdotme@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=christian.koenig@amd.com \
--cc=corbet@lwn.net \
--cc=daniel.vetter@ffwll.ch \
--cc=davem@davemloft.net \
--cc=deller@gmx.de \
--cc=donald.hunter@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=dsahern@kernel.org \
--cc=dw@davidwei.uk \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=hch@infradead.org \
--cc=herbert@gondor.apana.org.au \
--cc=hramamurthy@google.com \
--cc=ilias.apalodimas@linaro.org \
--cc=ink@jurassic.park.msu.ru \
--cc=jeroendb@google.com \
--cc=jgg@ziepe.ca \
--cc=kaiyuanz@google.com \
--cc=kuba@kernel.org \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=linyunsheng@huawei.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mattst88@gmail.com \
--cc=mhiramat@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pkaligineedi@google.com \
--cc=razor@blackwall.org \
--cc=richard.henderson@linaro.org \
--cc=rostedt@goodmis.org \
--cc=shailend@google.com \
--cc=shakeel.butt@linux.dev \
--cc=shuah@kernel.org \
--cc=sparclinux@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
--cc=sumit.semwal@linaro.org \
--cc=tsbogend@alpha.franken.de \
--cc=willemb@google.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox