From: John David Anglin <dave.anglin@bell.net>
To: Helge Deller <deller@gmx.de>,
linux-parisc <linux-parisc@vger.kernel.org>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
Subject: Re: v5.8.x stability on parisc
Date: Sun, 27 Sep 2020 17:24:19 -0400 [thread overview]
Message-ID: <60f8a51e-ac6e-d49c-e63e-d2b83cf4de22@bell.net> (raw)
In-Reply-To: <387e5574-a270-f3cc-d0f2-a26d0383b7e6@gmx.de>
On 2020-09-27 3:45 p.m., Helge Deller wrote:
> On 9/27/20 4:17 PM, John David Anglin wrote:
>> With this patch collection, I haven't seen any stalls on my rp3440 and c8000 running v5.8.x. Further,
>> I haven't had any signing failures on the buildd machine. The rp3440 (mx3210) has also been successful in
>> building several packages that failed multiple time on the c8000 buildd.
>>
>> I think this is due to the three changes at the bottom from Linus.
> Weren't thos added already upstream (or variants of them) ?
Thought so but nothing has been committed to v5.8.x that conflicts with the changes. I also searched the git log
for similar commits but I didn't find anything. So, I'm puzzled as to what happened to these changes. This is the
main reason I threw out my patch list for discussion.
The following packages built successfully on mx3210 after falling on c8000: tigervnc, postgresql-13, verse, bali-phy
and libbpf. I also tried mariadb-10.5 but it had the same testsuite fail as before.
>
>> diff --git a/arch/parisc/include/asm/barrier.h b/arch/parisc/include/asm/barrier.h
>> index 640d46edf32e..c705decf2bed 100644
>> --- a/arch/parisc/include/asm/barrier.h
>> +++ b/arch/parisc/include/asm/barrier.h
>> @@ -2,11 +2,15 @@
>> /* The synchronize caches instruction executes as a nop on systems in
>> which all memory references are performed in order. */
>> -#define synchronize_caches() __asm__ __volatile__ ("sync" : : : "memory")
>> +#define synchronize_caches() asm volatile("sync" \
>> + ALTERNATIVE(ALT_COND_NO_SMP, INSN_NOP) \
>> + : : : "memory")
> I wonder if this has any impact.
> If it's an UP system, won't this "sync" just be a "nop" anyway?
I believe we want this when SMP kernel is run on a UP machine or a SMP machine running with one CPU.
> Did you ran some performance tests, just to check?
No.
>
> Would you mind to send separate patches for each logical change?
>
I'll try to get there but I'm currently focusing on toolchain issues.
Regards,
Dave
--
John David Anglin dave.anglin@bell.net
next prev parent reply other threads:[~2020-09-27 21:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-27 14:17 v5.8.x stability on parisc John David Anglin
2020-09-27 19:45 ` Helge Deller
2020-09-27 21:24 ` John David Anglin [this message]
2020-09-29 18:00 ` John David Anglin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60f8a51e-ac6e-d49c-e63e-d2b83cf4de22@bell.net \
--to=dave.anglin@bell.net \
--cc=James.Bottomley@HansenPartnership.com \
--cc=deller@gmx.de \
--cc=linux-parisc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox