From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E6C5C07E99 for ; Fri, 9 Jul 2021 16:05:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F0ED1613B7 for ; Fri, 9 Jul 2021 16:05:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232366AbhGIQIC (ORCPT ); Fri, 9 Jul 2021 12:08:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53980 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232330AbhGIQIB (ORCPT ); Fri, 9 Jul 2021 12:08:01 -0400 Received: from mail.sf-mail.de (mail.sf-mail.de [IPv6:2a01:4f8:1c17:6fae:616d:6c69:616d:6c69]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BECD6C0613E5 for ; Fri, 9 Jul 2021 09:05:17 -0700 (PDT) Received: (qmail 5818 invoked from network); 9 Jul 2021 16:02:17 -0000 Received: from p548c7b0a.dip0.t-ipconnect.de ([::ffff:84.140.123.10]:37102 HELO daneel.sf-tec.de) (auth=eike@sf-mail.de) by mail.sf-mail.de (Qsmtpd 0.38dev) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPSA for ; Fri, 09 Jul 2021 18:02:17 +0200 From: Rolf Eike Beer To: James.Bottomley@hansenpartnership.com, Carlos Bilbao Cc: deller@gmx.de, linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drivers: parisc: Update iosapic driver with proper printks Date: Fri, 09 Jul 2021 18:05:05 +0200 Message-ID: <7261873.EvYhyI6sBW@daneel.sf-tec.de> In-Reply-To: <5760611.lOV4Wx5bFT@iron-maiden> References: <5760611.lOV4Wx5bFT@iron-maiden> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart3608610.kQq0lBPeGt"; micalg="pgp-sha1"; protocol="application/pgp-signature" Precedence: bulk List-ID: X-Mailing-List: linux-parisc@vger.kernel.org --nextPart3608610.kQq0lBPeGt Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Am Freitag, 9. Juli 2021, 15:38:44 CEST schrieb Carlos Bilbao: > The code from the old I/O Sapic Driver is outdated when it comes to printks. > Fix applying proper indentation and using dev_dbg() instead of printk on > debugging blocks. Also add a KERN_ where it is missing. Have you actually tried building this? I bet not: > +#define DBG(x...) dev_dbg(x) > + DBG("io_sapic_info at %p\n", isi); > + DBG("\t\tisi_hpa: %lx\n", isi->isi_hpa); > + DBG("\t\tisi_status: %x\n", isi->isi_status); > + DBG("\t\tisi_version: %x\n", isi->isi_version); > + DBG("\t\tisi_vector: %p\n", isi->isi_vector); > } > #endif /* DEBUG_IOSAPIC */ You are not passing a struct device here, so this will not work. Eike --nextPart3608610.kQq0lBPeGt Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQSaYVDeqwKa3fTXNeNcpIk+abn8TgUCYOhzsQAKCRBcpIk+abn8 TpaCAJ9mOyggOWP67DN4nfSxWms8582CewCfb47IkLCOfV43CQ9Q4Y4qoMnAqhE= =a80g -----END PGP SIGNATURE----- --nextPart3608610.kQq0lBPeGt--