From: baihaowen <baihaowen@meizu.com>
To: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: <netdev@vger.kernel.org>, <linux-parisc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net: tulip: de4x5: remove unused variable
Date: Thu, 2 Jun 2022 09:06:59 +0800 [thread overview]
Message-ID: <840dde56-18ab-40a6-d317-6288df5485ea@meizu.com> (raw)
In-Reply-To: <1654068277-6691-1-git-send-email-baihaowen@meizu.com>
在 2022/6/1 下午3:24, Haowen Bai 写道:
> The variable imr is initialized but never used otherwise.
>
> Signed-off-by: Haowen Bai <baihaowen@meizu.com>
> ---
> drivers/net/ethernet/dec/tulip/de4x5.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/dec/tulip/de4x5.c b/drivers/net/ethernet/dec/tulip/de4x5.c
> index 71730ef4cd57..40a54827d599 100644
> --- a/drivers/net/ethernet/dec/tulip/de4x5.c
> +++ b/drivers/net/ethernet/dec/tulip/de4x5.c
> @@ -3817,10 +3817,9 @@ de4x5_setup_intr(struct net_device *dev)
> {
> struct de4x5_private *lp = netdev_priv(dev);
> u_long iobase = dev->base_addr;
> - s32 imr, sts;
> + s32 sts;
>
> if (inl(DE4X5_OMR) & OMR_SR) { /* Only unmask if TX/RX is enabled */
> - imr = 0;
> UNMASK_IRQs;
> sts = inl(DE4X5_STS); /* Reset any pending (stale) interrupts */
> outl(sts, DE4X5_STS);
Sorry, ignore this patch.
--
Haowen Bai
prev parent reply other threads:[~2022-06-02 1:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-01 7:24 [PATCH] net: tulip: de4x5: remove unused variable Haowen Bai
2022-06-01 14:38 ` kernel test robot
2022-06-02 1:06 ` baihaowen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=840dde56-18ab-40a6-d317-6288df5485ea@meizu.com \
--to=baihaowen@meizu.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox