Re: [PATCH v3 10/24] sparc: Remove COMMAND_LINE_SIZE from uapi

John Paul Adrian Glaubitz
2023-02-14T10:40:12Z

On Tue, 2023-02-14 at 16:59 +0800, WANG Xuerui wrote:
> On 2023/2/14 16:50, Sergey Shtylyov wrote:
> > On 2/14/23 10:49 AM, Alexandre Ghiti wrote:
> >
> > > From: Palmer Dabbelt <palmer@rivosinc.com>
> > >
> > > As far as I can tell this is not used by userspace and thus should not
> > > be part of the user-visible API.
> > >
> > > Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>
> > > ---
> > > arch/sparc/include/asm/setup.h | 6 +++++-
> > > arch/sparc/include/uapi/asm/setup.h | 7 -------
> > > 2 files changed, 5 insertions(+), 8 deletions(-)
> > >
> > > diff --git a/arch/sparc/include/asm/setup.h b/arch/sparc/include/asm/setup.h
> > > index 72205684e51e..d1384ed92547 100644
> > > --- a/arch/sparc/include/asm/setup.h
> > > +++ b/arch/sparc/include/asm/setup.h
> > > @@ -7,7 +7,11 @@
> > >
> > > #include <linux/interrupt.h>
> > >
> > > -#include <uapi/asm/setup.h>
> > > +#if defined(__sparc__) && defined(__arch64__)
> >
> > Mhm, I don't think these two can be #define'd simulaneously...
>
> I believe it's just a SPARC-ism [1] [2] that may look strange and be
> easily confused for __aarch64__ (notice the extra 'a')...

Yep, that's correct. On 64-bit Linux/SPARC, gcc/clang define __sparc__ AND __arch64__.

Adrian

--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer
`. `' Physicist
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913