From: Florian Weimer <fweimer@redhat.com>
To: Helge Deller <deller@kernel.org>
Cc: libc-alpha@sourceware.org,
John David Anglin <dave.anglin@bell.net>,
linux-parisc@vger.kernel.org
Subject: Re: [PATCH] hppa: Wire up cacheflush syscall
Date: Mon, 08 Jul 2024 10:13:34 +0200 [thread overview]
Message-ID: <877cdwfgi9.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <Zos8gVaGUcuaaNaI@carbonx1> (Helge Deller's message of "Mon, 8 Jul 2024 03:10:25 +0200")
* Helge Deller:
> diff --git a/sysdeps/unix/sysv/linux/hppa/sys/cachectl.h b/sysdeps/unix/sysv/linux/hppa/sys/cachectl.h
> new file mode 100644
> index 0000000000..16e47d1329
> --- /dev/null
> +++ b/sysdeps/unix/sysv/linux/hppa/sys/cachectl.h
> @@ -0,0 +1,36 @@
> +#ifndef _SYS_CACHECTL_H
> +#define _SYS_CACHECTL_H 1
> +
> +#include <features.h>
> +
> +/* Get the kernel definition for the op bits. */
> +#include <asm/cachectl.h>
This makes this header (<sys/cachectl.h>) unusable with older kernel
headers. I think it also results in a test failure with older headers.
Is this a problem?
In similar cases, we use LINUX_VERSION_CODE checks (for older compilers)
and __has_include to support backports.
Thanks,
Florian
next prev parent reply other threads:[~2024-07-08 8:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-08 1:10 [PATCH] hppa: Wire up cacheflush syscall Helge Deller
2024-07-08 8:13 ` Florian Weimer [this message]
2024-07-08 8:58 ` Helge Deller
2024-07-08 16:00 ` Andreas K. Huettel
2024-07-08 18:26 ` Helge Deller
2024-07-09 13:41 ` Sam James
2024-08-03 8:57 ` John David Anglin
2024-09-26 19:08 ` Sam James
2024-09-27 7:16 ` Helge Deller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877cdwfgi9.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=dave.anglin@bell.net \
--cc=deller@kernel.org \
--cc=libc-alpha@sourceware.org \
--cc=linux-parisc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox