From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B78142594BD for ; Wed, 7 Jan 2026 04:58:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767761904; cv=none; b=H7ISPEWf6U6L9WYntz5+vBnV0KbN5w5nZEP9htUcBuRYIEE5ndUpEEpJUY0MhfcnGuoFp5Jti9cYaB6ONFfUgbDmr7e3H2GeYYTgVe/dOzFbwla50tfjTOoslfIi/3PoWBoKbvy0FrLzKlg7PJyat4lTuCctSZrMNE+XxlMfjsA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767761904; c=relaxed/simple; bh=u52IYXtkIGi8sisrJ2GXaZQiFovGjOBhfJtTiCU+FIM=; h=From:To:Cc:Subject:In-Reply-To:Date:Message-ID:References: MIME-Version:Content-Type; b=WOX6jIUJGg12PfiVl9JMLOyRCkNBVc3nFdpKAlzJor9AhLKlvNJGLbhVry5BWcr8IkU6Madz9CB9oC01U3l2SNK878hht2hfmRFC6PS7AHjMl5rVi0QYMmJ7XZ4G1eGehzPHFWK3zrH2qrGPpjOt2hvUnIPFnH+4ytGv4FZRuVM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XE9OHB7K; arc=none smtp.client-ip=209.85.216.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XE9OHB7K" Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-34c1d98ba11so1480150a91.3 for ; Tue, 06 Jan 2026 20:58:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767761902; x=1768366702; darn=vger.kernel.org; h=mime-version:references:message-id:date:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=nurUXHNs091EaceKYt0jtxQiBJ2IaAdTDr7CGJ+zWBU=; b=XE9OHB7Kl+IegOavGwsCniq7IfH569pyWSwOB3GH4IFakEzMoVU0qTAM99Htm/LTZa oIrdXqofABAYlYf0vbgd+n0GUNiJzVIPiyO8CScU6yhPMURk/UDM/RVMGFEztgjtLPNS WRPiIEJnD0Ff9/Z8WNMKc7Anw6/nMx8MAbq3s3xv9xn+5m1oNJCX1ktobB6O3+C+tCKf 0dT43+gSNEm71HVEC9CZgI8klLsPbgoiQqrHQwigH/O6I0GQ3Ti8owh0piXgvhZN4xe2 1m7D9Rr/nZ33sxwqrbUB/YINiEIurizt1znhUcLNHdGYLs9ErvXCDeFUGjhnGu4pVoK6 wLTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767761902; x=1768366702; h=mime-version:references:message-id:date:in-reply-to:subject:cc:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nurUXHNs091EaceKYt0jtxQiBJ2IaAdTDr7CGJ+zWBU=; b=c5unLro47aqvNP2waTI/jTFOWOlRLxJRLAQ3QpGhTO45pf3iRFUTUl3px5+DevFGES 6ZK+y8yh0BdinO+vpkbCCFA8lGGMYgEeY0Dvm9RxrXlRru1XrnZh8CRjfM85kjmpngMZ dStRaWHapUg9f+bTt7BsXiczdwHWvx8aYiiYLmE1mCJT5v1FPXw6cOfHncClRNxlk1/Z 015P0I8PChRPLD4APXhs1PYKA/2ezXsWXTUL9ZN0KNxH/D5WvpSdoi/oLCLK3q9h6QcP zif9neSHzsKKCYcFkTBdwTGFjS4imaWCbvSPL/Z9NZzfa/6KFLMkWJrWPhPN6sHIUT7L SeqA== X-Forwarded-Encrypted: i=1; AJvYcCWYLWXJpxAzfL2l7PRPgYFGnYvQFHDbZcLGJdZ+GLcCGltF+j5icEceoC1OG1WtZyzczlJmSL+G0mbDLDw=@vger.kernel.org X-Gm-Message-State: AOJu0YxpWaAXCgnNP4vVp9I8fHBk6hY+c/4KymHVVooFx6wHJANoTKgp UvLy6ePoVTHsUuJlCYzJsVDCZHS4VonnN1dbvKclHPvU4hByc6iLFaus X-Gm-Gg: AY/fxX4vSFdpktwovE6Ghpk40AExLCzOmBHNflN9UP/lR+kHwpMlQTdyjPHJZdzoZh/ SNLHC6989aHvxF10muSsa/cidS6SD0/5COVRvNE/sf806ROQt6AX+J9RYYFx4vc2ouJNBhTwjvJ z8mfygKSXI4nbqFbqjetLYljveV+zJuu4sr4acdXJEKdRJ+1ZmNquCu7W9aPJkoSqxnTwydCEGh ZVXcIhkxLSU1O00OT9rxcJ8LM0zcm29Y1kLG6qQHmqGx7AVuweskHRQyv5P0ArTx8mHnZ0JNh0f jaiPKHTM/8GQ4hw2orpUoFmgevfOnUYTQsZGrdQlkowlUbEa7IndmXHaszV3OeX2GpWbUvUDiRg HWfSxbVbBtnhH6XcKN+GPgzG5V0q4e6ntHvjStJluJogVK8TI9zNDGQnP8rUPqWnk6H0Qq3i1a/ 3G5qJfKw== X-Google-Smtp-Source: AGHT+IE3iEJ4twso46GOnqJPDopUox2qFLaKHiDPKI95vlPPxjV/F7mxvaI/CeOE2s8GrRHRScEd6Q== X-Received: by 2002:a17:90b:6c7:b0:335:2eef:4ca8 with SMTP id 98e67ed59e1d1-34f68d3b4a4mr1191743a91.33.1767761901762; Tue, 06 Jan 2026 20:58:21 -0800 (PST) Received: from dw-tp ([49.207.192.172]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-34f5fb75902sm3622895a91.16.2026.01.06.20.58.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Jan 2026 20:58:20 -0800 (PST) From: Ritesh Harjani (IBM) To: Mike Rapoport , Andrew Morton Cc: Alex Shi , Alexander Gordeev , Andreas Larsson , Borislav Petkov , Brian Cain , "Christophe Leroy (CS GROUP)" , Catalin Marinas , "David S. Miller" , Dave Hansen , David Hildenbrand , Dinh Nguyen , Geert Uytterhoeven , Guo Ren , Heiko Carstens , Helge Deller , Huacai Chen , Ingo Molnar , Johannes Berg , John Paul Adrian Glaubitz , Jonathan Corbet , "Liam R. Howlett" , Lorenzo Stoakes , Magnus Lindholm , Matt Turner , Max Filippov , Michael Ellerman , Michal Hocko , Michal Simek , Mike Rapoport , Muchun Song , Oscar Salvador , Palmer Dabbelt , Pratyush Yadav , Richard Weinberger , Russell King , Stafford Horne , Suren Baghdasaryan , Thomas Bogendoerfer , Thomas Gleixner , Vasily Gorbik , Vineet Gupta , Vlastimil Babka , Will Deacon , x86@kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-cxl@vger.kernel.org, linux-doc@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-um@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, sparclinux@vger.kernel.org Subject: Re: [PATCH v2 14/28] powerpc: introduce arch_zone_limits_init() In-Reply-To: <20260102070005.65328-15-rppt@kernel.org> Date: Wed, 07 Jan 2026 09:57:34 +0530 Message-ID: <87ldia9he1.ritesh.list@gmail.com> References: <20260102070005.65328-1-rppt@kernel.org> <20260102070005.65328-15-rppt@kernel.org> Precedence: bulk X-Mailing-List: linux-parisc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Mike Rapoport writes: > From: "Mike Rapoport (Microsoft)" > > Move calculations of zone limits to a dedicated arch_zone_limits_init() > function. > > Later MM core will use this function as an architecture specific callback > during nodes and zones initialization and thus there won't be a need to > call free_area_init() from every architecture. > > Signed-off-by: Mike Rapoport (Microsoft) > --- > arch/powerpc/mm/mem.c | 22 ++++++++++++---------- > 1 file changed, 12 insertions(+), 10 deletions(-) > > diff --git a/arch/powerpc/mm/mem.c b/arch/powerpc/mm/mem.c > index 3ddbfdbfa941..32c496bfab4f 100644 > --- a/arch/powerpc/mm/mem.c > +++ b/arch/powerpc/mm/mem.c > @@ -221,13 +221,23 @@ static int __init mark_nonram_nosave(void) > * anyway) will take a first dip into ZONE_NORMAL and get otherwise served by > * ZONE_DMA. > */ > -static unsigned long max_zone_pfns[MAX_NR_ZONES]; > +void __init arch_zone_limits_init(unsigned long *max_zone_pfns) > +{ > +#ifdef CONFIG_ZONE_DMA > + max_zone_pfns[ZONE_DMA] = min(zone_dma_limit, max_low_pfn - 1) + 1; Hi Mike, This doesn't look correct. Isn't the zone_dma_limit value in bytes actually? Shouldn't it be - max_zone_pfns[ZONE_DMA] = min((zone_dma_limit >> PAGE_SHIFT) + 1, max_low_pfn); -ritesh > +#endif > + max_zone_pfns[ZONE_NORMAL] = max_low_pfn; > +#ifdef CONFIG_HIGHMEM > + max_zone_pfns[ZONE_HIGHMEM] = max_pfn; > +#endif > +} > > /* > * paging_init() sets up the page tables - in fact we've already done this. > */ > void __init paging_init(void) > { > + unsigned long max_zone_pfns[MAX_NR_ZONES]; > unsigned long long total_ram = memblock_phys_mem_size(); > phys_addr_t top_of_ram = memblock_end_of_DRAM(); > int zone_dma_bits; > @@ -259,15 +269,7 @@ void __init paging_init(void) > > zone_dma_limit = DMA_BIT_MASK(zone_dma_bits); > > -#ifdef CONFIG_ZONE_DMA > - max_zone_pfns[ZONE_DMA] = min(max_low_pfn, > - 1UL << (zone_dma_bits - PAGE_SHIFT)); > -#endif > - max_zone_pfns[ZONE_NORMAL] = max_low_pfn; > -#ifdef CONFIG_HIGHMEM > - max_zone_pfns[ZONE_HIGHMEM] = max_pfn; > -#endif > - > + arch_zone_limits_init(max_zone_pfns); > free_area_init(max_zone_pfns); > > mark_nonram_nosave(); > -- > 2.51.0