Re: [patch v3 13/36] x86/smpboot: Remove cpu_callin_mask

Thomas Gleixner
2023-05-09T12:10:04Z

On Tue, May 09 2023 at 12:49, Peter Zijlstra wrote:
> On Mon, May 08, 2023 at 09:43:47PM +0200, Thomas Gleixner wrote:
>> - /*
>> - * Sync point with wait_cpu_callin(). The AP doesn't wait here
>> - * but just sets the bit to let the controlling CPU (BSP) know that
>> - * it's got this far.
>> - */
>> smp_callin();
>>
>> /* Otherwise gcc will move up smp_processor_id() before cpu_init() */
>
> Good riddance to that mask; however is smp_callin() still an appropriate
> name for that function?
>
> Would smp_starting() -- seeing how this kicks of CPU_STARTING not be a
> better name?

Something like that, yes.