From: David Huggins-Daines <dhd@linuxcare.com>
To: Alan Modra <alan@linuxcare.com.au>
Cc: parisc-linux@thepuffingroup.com, parisc@lists.linuxcare.com
Subject: Re: Incompatibility of PIC and non-PIC
Date: 19 Aug 2000 18:00:21 -0400 [thread overview]
Message-ID: <87r97kzzbe.fsf@linuxcare.com> (raw)
In-Reply-To: David Huggins-Daines's message of "18 Aug 2000 16:14:27 -0400"
David Huggins-Daines <dhd@linuxcare.com> writes:
> @@ -1961,8 +1961,8 @@
> || (h->elf_link_hash_flags & ELF_LINK_HASH_NEEDS_PLT) != 0)
> {
> if (h->plt.refcount <= 0
> + || h->root.type == bfd_link_hash_undefweak
> || ((h->elf_link_hash_flags & ELF_LINK_HASH_DEF_REGULAR) != 0
> - && h->root.type != bfd_link_hash_defweak
> && (!info->shared || info->symbolic)
> && !(!info->shared
> && (h->root.type == bfd_link_hash_defined
This chunk needs to also check for undefined symbols, it seems.
Here's a better one:
@@ -1961,8 +1961,9 @@
|| (h->elf_link_hash_flags & ELF_LINK_HASH_NEEDS_PLT) != 0)
{
if (h->plt.refcount <= 0
+ || h->root.type == bfd_link_hash_undefweak
+ || h->root.type == bfd_link_hash_undefined
|| ((h->elf_link_hash_flags & ELF_LINK_HASH_DEF_REGULAR) != 0
- && h->root.type != bfd_link_hash_defweak
&& (!info->shared || info->symbolic)
&& !(!info->shared
&& (h->root.type == bfd_link_hash_defined
--
dhd@linuxcare.com, http://www.linuxcare.com/
Linuxcare. Support for the revolution.
next prev parent reply other threads:[~2000-08-19 22:01 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-08-17 22:25 [parisc-linux] Incompatibility of PIC and non-PIC David Huggins-Daines
2000-08-18 0:12 ` Alan Modra
2000-08-18 14:29 ` Alan Modra
2000-08-18 17:25 ` David Huggins-Daines
2000-08-18 20:14 ` David Huggins-Daines
2000-08-18 23:35 ` Alan Modra
2000-08-19 5:29 ` Alan Modra
2000-08-21 17:46 ` David Huggins-Daines
2000-08-21 19:09 ` David Huggins-Daines
2000-08-21 23:39 ` Alan Modra
2000-08-19 22:00 ` David Huggins-Daines [this message]
2000-08-20 3:07 ` Alan Modra
2000-08-20 2:43 ` Matthew Wilcox
2000-08-20 4:19 ` Alan Modra
2000-08-21 13:41 ` David Huggins-Daines
2000-08-21 13:38 ` David Huggins-Daines
[not found] <alan@linuxcare.com.au>
2000-08-23 8:49 ` Tor Arntsen
2000-08-23 9:49 ` Alan Modra
-- strict thread matches above, loose matches on Subject: below --
2000-08-23 10:31 Tor Arntsen
2000-08-23 10:46 ` Alan Modra
2000-08-23 11:26 Tor Arntsen
2000-08-23 13:51 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r97kzzbe.fsf@linuxcare.com \
--to=dhd@linuxcare.com \
--cc=alan@linuxcare.com.au \
--cc=parisc-linux@thepuffingroup.com \
--cc=parisc@lists.linuxcare.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox