From: Jeffrey A Law <law@redhat.com>
To: Alan Modra <alan@linuxcare.com.au>
Cc: John David Anglin <dave@hiauly1.hia.nrc.ca>,
gcc-patches@gcc.gnu.org, parisc-linux@puffin.external.hp.com
Subject: Re: Oust HPPA PIC_OFFSET_TABLE_REGNUM_SAVED
Date: Mon, 15 Jan 2001 10:46:59 -0700 [thread overview]
Message-ID: <9023.979580819@upchuck.cygnus.com> (raw)
In-Reply-To: Your message of Mon, 15 Jan 2001 22:09:30 +1100. <Pine.LNX.4.21.0101151430350.21322-100000@front.linuxcare.com.au>
In message <Pine.LNX.4.21.0101151430350.21322-100000@front.linuxcare.com.au>y
ou write:
> This patch rids us of PIC_OFFSET_TABLE_REGNUM_SAVED, and the problems that
> go with it. Additionally, I reload the pic offset table register before
> calls to guard against asm trashing r27/r19. Hasn't bootstrapped yet, but
> looks promising. One possible fly in the ointment is whether any ABI
> requires that r4 always be used to save the pic offset table reg.
>
> * config/pa/pa.h (PIC_OFFSET_TABLE_REGNUM_SAVED): Remove.
> (machine_function): Define.
> (PIC_OFFSET_TABLE_SAVE_RTX) : Define.
> (INIT_EXPANDERS): Define.
> * config/pa/pa.c (pa_init_machine_status, pa_free_machine_status,
> pa_init_expanders): New functions.
> (hppa_expand_prologue): Use PIC_OFFSET_TABLE_SAVE_RTX instead of
> PIC_OFFSET_TABLE_REGNUM_SAVED.
> * config/pa/pa.md: Use PIC_OFFSET_TABLE_SAVE_RTX instead of
> PIC_OFFSET_TABLE_REGNUM_SAVED throughout. Restore pic offset
> table register before all calls as well as after.
> * config/pa/pa32-regs.h (CONDITIONAL_REGISTER_USAGE): Remove
> references to PIC_OFFSET_TABLE_REGNUM_SAVED.
> * config/pa/pa64-regs.h (CONDITIONAL_REGISTER_USAGE): Likewise.
First, if an ASM trashes a fixed register, then it is the ASM's responsibility
to restore it. So that part of this patch is wrong.
The rest of it looks pretty reasonable and can be installed.
jeff
next prev parent reply other threads:[~2001-01-15 17:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Pine.LNX.4.21.0101151238510.21322-100000@front.linuxcare.com.au>
2001-01-15 11:09 ` [parisc-linux] Oust HPPA PIC_OFFSET_TABLE_REGNUM_SAVED Alan Modra
2001-01-15 16:24 ` John David Anglin
2001-01-15 16:38 ` Jeffrey A Law
2001-01-15 23:17 ` Alan Modra
2001-01-15 17:46 ` Jeffrey A Law [this message]
2001-01-15 23:07 ` Alan Modra
2001-01-16 1:20 ` Alan Modra
2001-01-16 5:53 ` Richard Henderson
2001-01-16 9:28 ` Alan Modra
2001-01-17 3:23 ` John David Anglin
2001-01-17 3:54 ` John David Anglin
2001-01-17 5:26 ` Jeffrey A Law
2001-01-17 5:30 ` Jeffrey A Law
2001-01-17 5:59 ` John David Anglin
2001-01-17 7:24 ` Alan Modra
2001-01-17 16:09 ` Jeffrey A Law
2001-01-17 16:22 ` John David Anglin
2001-01-17 21:42 ` Jeffrey A Law
2001-01-17 22:20 ` John David Anglin
2001-01-18 6:04 ` John David Anglin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9023.979580819@upchuck.cygnus.com \
--to=law@redhat.com \
--cc=alan@linuxcare.com.au \
--cc=dave@hiauly1.hia.nrc.ca \
--cc=gcc-patches@gcc.gnu.org \
--cc=parisc-linux@puffin.external.hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox