From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C743CD4847 for ; Fri, 22 Sep 2023 17:43:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232461AbjIVRnQ (ORCPT ); Fri, 22 Sep 2023 13:43:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41748 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232297AbjIVRnO (ORCPT ); Fri, 22 Sep 2023 13:43:14 -0400 Received: from omta036.useast.a.cloudfilter.net (omta036.useast.a.cloudfilter.net [44.202.169.35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7DC98FB for ; Fri, 22 Sep 2023 10:43:08 -0700 (PDT) Received: from eig-obgw-6001a.ext.cloudfilter.net ([10.0.30.140]) by cmsmtp with ESMTP id jjU1qYGOPDKaKjkBHqDSxy; Fri, 22 Sep 2023 17:43:07 +0000 Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with ESMTPS id jkBGqZkcXcrKejkBHqq8m4; Fri, 22 Sep 2023 17:43:07 +0000 X-Authority-Analysis: v=2.4 cv=BvCOfKb5 c=1 sm=1 tr=0 ts=650dd22b a=1YbLdUo/zbTtOZ3uB5T3HA==:117 a=P7XfKmiOJ4/qXqHZrN7ymg==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=IkcTkHD0fZMA:10 a=zNV7Rl7Rt7sA:10 a=wYkD_t78qR0A:10 a=NEAV23lmAAAA:8 a=J1Y8HTJGAAAA:8 a=VwQbUJbxAAAA:8 a=1XWaLZrsAAAA:8 a=20KFwNOVAAAA:8 a=cm27Pg_UAAAA:8 a=YSKGN3ub9cUXa_79IdMA:9 a=QEXdDO2ut3YA:10 a=y1Q9-5lHfBjTkpIzbSAN:22 a=AjGcO6oz07-iQ99wixmX:22 a=xmb-EsYY8bH0VWELuYED:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=embeddedor.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=uqrrds5r8x3t4h70fPgAZPNbhElh0SPzheRmzA+S1Gc=; b=rrY9boyYQLlrCMg3B82ApBf77m 4u20ugIPr446534HlrJ3UKFEfNBD7TOBQIMBghM5UDfXJ6GTIBbCP2sZtHx+VPRLQD7tYoeml5mch BzHR443B/l88uxreKTxIwKaUexpLyYV6xbeKqWPJr5aL7mNIpZ9ekcmFbsFK5f3s8AxIM7eZjbYhx PUJoDtK5dU90jKugA0AmC4Mw0uOFNaFZjZCVnWAo0XITWDHuTN7VSQKfSetb/sUBtMjRilt9ywz1p jk+IocehBFp69RhQ6/FtP4pFUmd5Gwq9TfRBRDCYNrhXSvON22FmDfiRTRCNjDfrryhr4zu5EhU5y KCUuAEPQ==; Received: from [94.239.20.48] (port=44586 helo=[192.168.1.98]) by gator4166.hostgator.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1qjkBA-004H78-2r; Fri, 22 Sep 2023 12:43:01 -0500 Message-ID: <9fd84065-4191-c8c6-43fa-01eda9865dd2@embeddedor.com> Date: Fri, 22 Sep 2023 19:43:57 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH 01/14] ipv4: Annotate struct fib_info with __counted_by Content-Language: en-US To: Kees Cook , Jakub Kicinski Cc: "David S. Miller" , David Ahern , Eric Dumazet , Paolo Abeni , netdev@vger.kernel.org, Jamal Hadi Salim , Martin KaFai Lau , "Gustavo A. R. Silva" , Alexei Starovoitov , Yisen Zhuang , Salil Mehta , Claudiu Manoil , Vladimir Oltean , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Sharma , Alex Elder , Pravin B Shelar , Shaokun Zhang , Cong Wang , Jiri Pirko , Nathan Chancellor , Nick Desaulniers , Tom Rix , Simon Horman , linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-rdma@vger.kernel.org, dev@openvswitch.org, linux-parisc@vger.kernel.org, llvm@lists.linux.dev, linux-hardening@vger.kernel.org References: <20230922172449.work.906-kees@kernel.org> <20230922172858.3822653-1-keescook@chromium.org> From: "Gustavo A. R. Silva" In-Reply-To: <20230922172858.3822653-1-keescook@chromium.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 94.239.20.48 X-Source-L: No X-Exim-ID: 1qjkBA-004H78-2r X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.1.98]) [94.239.20.48]:44586 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 3 X-Org: HG=hgshared;ORG=hostgator; X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfJ8sENFjJHtc8CN1+mY8xqUZs3GjDMy/b9nLS7SH/auhvvHnWGql6b1SfKTrpd2sA9DMoZjLdUZ+jV76Qflukx7xbtg8EIDwa2z3WY7irDAYH3tsyN7Z VL4Zht54kBrLTDIE2F42V1vE5VwNcqvUjacfhRgFCYofd8GFqLlTmB01L6aP0UyP0/14cbsI9VZjUA+euR+SbJ+SMARHqCpPzuROFULThC5iB7/ZLc2dTOYH Precedence: bulk List-ID: X-Mailing-List: linux-parisc@vger.kernel.org On 9/22/23 11:28, Kees Cook wrote: > Prepare for the coming implementation by GCC and Clang of the __counted_by > attribute. Flexible array members annotated with __counted_by can have > their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS > (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family > functions). > > As found with Coccinelle[1], add __counted_by for struct fib_info. > > [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci > > Cc: "David S. Miller" > Cc: David Ahern > Cc: Eric Dumazet > Cc: Jakub Kicinski > Cc: Paolo Abeni > Cc: netdev@vger.kernel.org > Signed-off-by: Kees Cook Reviewed-by: Gustavo A. R. Silva Thanks -- Gustavo > --- > include/net/ip_fib.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/net/ip_fib.h b/include/net/ip_fib.h > index f0c13864180e..84b0a82c9df4 100644 > --- a/include/net/ip_fib.h > +++ b/include/net/ip_fib.h > @@ -156,7 +156,7 @@ struct fib_info { > bool nh_updated; > struct nexthop *nh; > struct rcu_head rcu; > - struct fib_nh fib_nh[]; > + struct fib_nh fib_nh[] __counted_by(fib_nhs); > }; > >