public inbox for linux-parisc@vger.kernel.org
 help / color / mirror / Atom feed
From: John David Anglin <dave.anglin@bell.net>
To: John David Anglin <dave.anglin@bell.net>
Cc: Jeroen Roovers <jer@gentoo.org>,
	linux-parisc@vger.kernel.org, Helge Deller <deller@gmx.de>
Subject: Re: PA8800 with 3.9.0-rc1-JeR-10942-g6dbe51c : WARNING: at lib/timerqueue.c:74
Date: Wed, 20 Mar 2013 22:02:55 -0400	[thread overview]
Message-ID: <BLU0-SMTP790A969254E562667034B397EB0@phx.gbl> (raw)
In-Reply-To: <514A183A.7090809@bell.net>

[-- Attachment #1: Type: text/plain, Size: 428 bytes --]

On 20-Mar-13, at 4:12 PM, John David Anglin wrote:

> On 3/20/2013 1:27 PM, Jeroen Roovers wrote:
>> +CONFIG_PREEMPT_NONE=y
> Given that CONFIG_PREEMPT is broken, we must be missing at least one
> preempt_disable()/preempt_enable() pair.


You might try the attached change.  My rp3440 booted with  
CONFIG_PREEMPT=y
and CONFIG_PREEMPT_NONE=y with it.  The fix is just a guess.

Dave
--
John David Anglin	dave.anglin@bell.net



[-- Attachment #2: linux-3.9-rc3-20130320.d.txt --]
[-- Type: text/plain, Size: 465 bytes --]

diff --git a/arch/parisc/kernel/cache.c b/arch/parisc/kernel/cache.c
index 4b12890..1871724 100644
--- a/arch/parisc/kernel/cache.c
+++ b/arch/parisc/kernel/cache.c
@@ -372,10 +372,12 @@ void flush_kernel_dcache_page_addr(void *addr)
 {
 	unsigned long flags;
 
+	preempt_disable();
 	flush_kernel_dcache_page_asm(addr);
 	purge_tlb_start(flags);
 	pdtlb_kernel(addr);
 	purge_tlb_end(flags);
+	preempt_enable();
 }
 EXPORT_SYMBOL(flush_kernel_dcache_page_addr);
 

  reply	other threads:[~2013-03-21  2:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-15 14:22 PA8800 with 3.9.0-rc1-JeR-10942-g6dbe51c : WARNING: at lib/timerqueue.c:74 Jeroen Roovers
2013-03-16 22:34 ` John David Anglin
2013-03-18 12:58   ` Jeroen Roovers
2013-03-19 22:38     ` Helge Deller
2013-03-19 22:49       ` John David Anglin
2013-03-20 17:27       ` Jeroen Roovers
2013-03-20 19:34         ` Jeroen Roovers
2013-03-20 20:12         ` John David Anglin
2013-03-21  2:02           ` John David Anglin [this message]
2013-03-21 14:57             ` Jeroen Roovers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BLU0-SMTP790A969254E562667034B397EB0@phx.gbl \
    --to=dave.anglin@bell.net \
    --cc=deller@gmx.de \
    --cc=jer@gentoo.org \
    --cc=linux-parisc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox