Re: [PATCH v3 10/24] sparc: Remove COMMAND_LINE_SIZE from uapi

Sergey Shtylyov
2023-02-14T08:50:54Z

On 2/14/23 10:49 AM, Alexandre Ghiti wrote:

> From: Palmer Dabbelt <palmer@rivosinc.com>
>
> As far as I can tell this is not used by userspace and thus should not
> be part of the user-visible API.
>
> Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>
> ---
> arch/sparc/include/asm/setup.h | 6 +++++-
> arch/sparc/include/uapi/asm/setup.h | 7 -------
> 2 files changed, 5 insertions(+), 8 deletions(-)
>
> diff --git a/arch/sparc/include/asm/setup.h b/arch/sparc/include/asm/setup.h
> index 72205684e51e..d1384ed92547 100644
> --- a/arch/sparc/include/asm/setup.h
> +++ b/arch/sparc/include/asm/setup.h
> @@ -7,7 +7,11 @@
>
> #include <linux/interrupt.h>
>
> -#include <uapi/asm/setup.h>
> +#if defined(__sparc__) && defined(__arch64__)

Mhm, I don't think these two can be #define'd simulaneously...

> +# define COMMAND_LINE_SIZE 2048
> +#else
> +# define COMMAND_LINE_SIZE 256
> +#endif
>
> extern char reboot_command[];
>
> diff --git a/arch/sparc/include/uapi/asm/setup.h b/arch/sparc/include/uapi/asm/setup.h
> index 3c208a4dd464..c3cf1b0d30b3 100644
> --- a/arch/sparc/include/uapi/asm/setup.h
> +++ b/arch/sparc/include/uapi/asm/setup.h
> @@ -6,11 +6,4 @@
> #ifndef _UAPI_SPARC_SETUP_H
> #define _UAPI_SPARC_SETUP_H
>
> -#if defined(__sparc__) && defined(__arch64__)
> -# define COMMAND_LINE_SIZE 2048
> -#else
> -# define COMMAND_LINE_SIZE 256
> -#endif
> -
> -
> #endif /* _UAPI_SPARC_SETUP_H */

MBR, Sergey