From: Helge Deller <deller@gmx.de>
To: linux-parisc@vger.kernel.org,
James Bottomley <James.Bottomley@hansenpartnership.com>,
John David Anglin <dave.anglin@bell.net>
Subject: [PATCH][RFC] parisc: Use local tlb purges only on PA2.0 machines
Date: Sun, 25 Sep 2022 20:57:23 +0200 [thread overview]
Message-ID: <YzCkkyktEZFM0svQ@p100> (raw)
Allow usage of CPU-local tlb purges in pacache.S on PA2.0 machines only.
Signed-off-by: Helge Deller <deller@gmx.de>
diff --git a/arch/parisc/kernel/pacache.S b/arch/parisc/kernel/pacache.S
index 9a0018f1f42c..7c23fcb737a9 100644
--- a/arch/parisc/kernel/pacache.S
+++ b/arch/parisc/kernel/pacache.S
@@ -31,6 +31,12 @@
.section .text.hot
.align 16
+#ifdef CONFIG_PA20
+#define ALT_COND_PACACHE ALT_COND_ALWAYS
+#else
+#define ALT_COND_PACACHE ALT_COND_NO_SMP
+#endif
+
ENTRY_CFI(flush_tlb_all_local)
/*
* The pitlbe and pdtlbe instructions should only be used to
@@ -539,15 +545,10 @@ ENTRY_CFI(copy_user_page_asm)
/* Purge any old translations */
-#ifdef CONFIG_PA20
- pdtlb,l %r0(%r28)
- pdtlb,l %r0(%r29)
-#else
0: pdtlb %r0(%r28)
1: pdtlb %r0(%r29)
- ALTERNATIVE(0b, 0b+4, ALT_COND_NO_SMP, INSN_PxTLB)
- ALTERNATIVE(1b, 1b+4, ALT_COND_NO_SMP, INSN_PxTLB)
-#endif
+ ALTERNATIVE(0b, 0b+4, ALT_COND_PACACHE, INSN_PxTLB)
+ ALTERNATIVE(1b, 1b+4, ALT_COND_PACACHE, INSN_PxTLB)
#ifdef CONFIG_64BIT
/* PA8x00 CPUs can consume 2 loads or 1 store per cycle.
@@ -670,12 +671,8 @@ ENTRY_CFI(clear_user_page_asm)
/* Purge any old translation */
-#ifdef CONFIG_PA20
- pdtlb,l %r0(%r28)
-#else
0: pdtlb %r0(%r28)
- ALTERNATIVE(0b, 0b+4, ALT_COND_NO_SMP, INSN_PxTLB)
-#endif
+ ALTERNATIVE(0b, 0b+4, ALT_COND_PACACHE, INSN_PxTLB)
#ifdef CONFIG_64BIT
ldi (PAGE_SIZE / 128), %r1
@@ -736,12 +733,8 @@ ENTRY_CFI(flush_dcache_page_asm)
/* Purge any old translation */
-#ifdef CONFIG_PA20
- pdtlb,l %r0(%r28)
-#else
0: pdtlb %r0(%r28)
- ALTERNATIVE(0b, 0b+4, ALT_COND_NO_SMP, INSN_PxTLB)
-#endif
+ ALTERNATIVE(0b, 0b+4, ALT_COND_PACACHE, INSN_PxTLB)
88: ldil L%dcache_stride, %r1
ldw R%dcache_stride(%r1), r31
@@ -785,12 +778,8 @@ ENTRY_CFI(purge_dcache_page_asm)
/* Purge any old translation */
-#ifdef CONFIG_PA20
- pdtlb,l %r0(%r28)
-#else
0: pdtlb %r0(%r28)
- ALTERNATIVE(0b, 0b+4, ALT_COND_NO_SMP, INSN_PxTLB)
-#endif
+ ALTERNATIVE(0b, 0b+4, ALT_COND_PACACHE, INSN_PxTLB)
88: ldil L%dcache_stride, %r1
ldw R%dcache_stride(%r1), r31
@@ -837,17 +826,11 @@ ENTRY_CFI(flush_icache_page_asm)
* have a flat address space, it's not clear which TLB will be
* used. So, we purge both entries. */
-#ifdef CONFIG_PA20
- pdtlb,l %r0(%r28)
-1: pitlb,l %r0(%sr4,%r28)
- ALTERNATIVE(1b, 1b+4, ALT_COND_NO_SPLIT_TLB, INSN_NOP)
-#else
0: pdtlb %r0(%r28)
1: pitlb %r0(%sr4,%r28)
- ALTERNATIVE(0b, 0b+4, ALT_COND_NO_SMP, INSN_PxTLB)
- ALTERNATIVE(1b, 1b+4, ALT_COND_NO_SMP, INSN_PxTLB)
+ ALTERNATIVE(0b, 0b+4, ALT_COND_PACACHE, INSN_PxTLB)
+ ALTERNATIVE(1b, 1b+4, ALT_COND_PACACHE, INSN_PxTLB)
ALTERNATIVE(1b, 1b+4, ALT_COND_NO_SPLIT_TLB, INSN_NOP)
-#endif
88: ldil L%icache_stride, %r1
ldw R%icache_stride(%r1), %r31
next reply other threads:[~2022-09-25 18:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-25 18:57 Helge Deller [this message]
2022-09-25 20:02 ` [PATCH][RFC] parisc: Use local tlb purges only on PA2.0 machines John David Anglin
2022-09-25 20:11 ` Helge Deller
2022-09-25 20:28 ` John David Anglin
2022-09-27 20:06 ` Helge Deller
2022-09-27 22:06 ` John David Anglin
2022-09-28 9:25 ` Helge Deller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzCkkyktEZFM0svQ@p100 \
--to=deller@gmx.de \
--cc=James.Bottomley@hansenpartnership.com \
--cc=dave.anglin@bell.net \
--cc=linux-parisc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox