public inbox for linux-parisc@vger.kernel.org
 help / color / mirror / Atom feed
From: Helge Deller <deller@gmx.de>
To: linux-parisc@vger.kernel.org
Subject: [PATCH] parisc: improve cach flushing in arch_sync_dma_for_cpu()
Date: Mon, 15 May 2023 20:39:33 +0200	[thread overview]
Message-ID: <ZGJ8ZcPZbckX7VNB@p100> (raw)

Handle the direction flag in arch_sync_dma_for_device() and
arch_sync_dma_for_cpu().

When receiving data from the device (DMA_FROM_DEVICE and DMA_BIDIRECTIONAL)
purge the data cache in arch_sync_dma_for_cpu().

Run-tested on C8000 workstation.

Signed-off-by: Helge Deller <deller@gmx.de>

diff --git a/arch/parisc/kernel/pci-dma.c b/arch/parisc/kernel/pci-dma.c
index ba87f791323b..f8337c1820fc 100644
--- a/arch/parisc/kernel/pci-dma.c
+++ b/arch/parisc/kernel/pci-dma.c
@@ -446,11 +446,36 @@ void arch_dma_free(struct device *dev, size_t size, void *vaddr,
 void arch_sync_dma_for_device(phys_addr_t paddr, size_t size,
 		enum dma_data_direction dir)
 {
-	flush_kernel_dcache_range((unsigned long)phys_to_virt(paddr), size);
+	unsigned long addr = (unsigned long) phys_to_virt(paddr);
+
+	switch (dir) {
+	case DMA_TO_DEVICE:
+		flush_kernel_dcache_range(addr, size);
+		break;
+	case DMA_FROM_DEVICE:
+	case DMA_BIDIRECTIONAL:
+		flush_kernel_dcache_range(addr, size);
+		purge_kernel_dcache_range_asm(addr, addr + size);
+		break;
+	default:
+		BUG();
+	}
 }

 void arch_sync_dma_for_cpu(phys_addr_t paddr, size_t size,
 		enum dma_data_direction dir)
 {
-	flush_kernel_dcache_range((unsigned long)phys_to_virt(paddr), size);
+	unsigned long addr = (unsigned long) phys_to_virt(paddr);
+
+	switch (dir) {
+	case DMA_TO_DEVICE:
+		flush_kernel_dcache_range(addr, size);
+		return;
+	case DMA_FROM_DEVICE:
+	case DMA_BIDIRECTIONAL:
+		purge_kernel_dcache_range_asm(addr, addr + size);
+		break;
+	default:
+		BUG();
+	}
 }

             reply	other threads:[~2023-05-15 18:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-15 18:39 Helge Deller [this message]
2023-05-15 22:28 ` [PATCH] parisc: improve cach flushing in arch_sync_dma_for_cpu() John David Anglin
2023-05-16  7:09   ` Helge Deller
2023-05-16 14:20     ` John David Anglin
2023-05-16 18:00       ` Helge Deller
2023-05-19 16:07         ` John David Anglin
2023-05-20  5:10           ` Helge Deller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZGJ8ZcPZbckX7VNB@p100 \
    --to=deller@gmx.de \
    --cc=linux-parisc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox