From: Tejun Heo <tj@kernel.org>
To: Helge Deller <deller@gmx.de>
Cc: Helge Deller <deller@kernel.org>,
Lai Jiangshan <jiangshanlai@gmail.com>,
linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org
Subject: Re: [PATCH][RFC] workqueue: Fix kernel panic on CPU hot-unplug
Date: Fri, 2 Feb 2024 07:29:16 -1000 [thread overview]
Message-ID: <Zb0mbHlIud_bqftx@slm.duckdns.org> (raw)
In-Reply-To: <f75e7606-0904-4e97-b337-e8f74843e87d@gmx.de>
Hello, Helge.
On Fri, Feb 02, 2024 at 09:41:38AM +0100, Helge Deller wrote:
> In a second step I extended your patch to print the present
> and online CPUs too. Below is the relevant dmesg part.
>
> Note, that on parisc the second CPU will be activated later in the
> boot process, after the kernel has the inventory.
> This I think differs vs x86, where all CPUs are available earlier
> in the boot process.
> ...
> [ 0.000000] XXX workqueue_init_early: possible_cpus=ffff present=0001 online=0001
...
> [ 0.228080] XXX workqueue_init: possible_cpus=ffff present=0001 online=0001
...
> [ 0.263466] XXX workqueue_init_topology: possible_cpus=ffff present=0001 online=0001
So, what's bothersome is that when the wq_dump.py script printing each cpu's
pwq, it's only printing for CPU 0 and 1. The for_each_possible_cpu() drgn
helper reads cpu_possible_mask from the kernel and iterates that, so that
most likely indicates at some point the cpu_possible_mask becomes 0x3
instead of the one used during boot - 0xffff, which is problematic.
Can you please sprinkle more printks to find out whether and when the
cpu_possible_mask changes during boot?
Thanks.
--
tejun
next prev parent reply other threads:[~2024-02-02 17:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-31 19:27 [PATCH][RFC] workqueue: Fix kernel panic on CPU hot-unplug Helge Deller
2024-01-31 22:28 ` Tejun Heo
2024-02-01 16:41 ` Helge Deller
2024-02-01 16:54 ` Tejun Heo
2024-02-01 17:56 ` Helge Deller
2024-02-02 1:39 ` Tejun Heo
2024-02-02 8:28 ` Helge Deller
2024-02-02 8:41 ` Helge Deller
2024-02-02 17:29 ` Tejun Heo [this message]
2024-02-05 9:58 ` Helge Deller
2024-02-05 17:45 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zb0mbHlIud_bqftx@slm.duckdns.org \
--to=tj@kernel.org \
--cc=deller@gmx.de \
--cc=deller@kernel.org \
--cc=jiangshanlai@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox