* [PATCH] ipl: adjust firmware entry type
@ 2025-08-30 15:22 Vincent Stehlé
2025-08-30 15:25 ` Vincent Stehlé
0 siblings, 1 reply; 2+ messages in thread
From: Vincent Stehlé @ 2025-08-30 15:22 UTC (permalink / raw)
To: linux-parisc; +Cc: Vincent Stehlé, Helge Deller
The `firmware_entry' function typedef used to call the firmware in
firmware_call() is defined with no argument.
This causes the compilation to fail with gcc 15:
pdc_misc.c:119:14: error: too many arguments to function ‘(int (*)(void))(unsigned int)fn’; expected 0, have 14
Add all the 14 function arguments to the type definition to fix the
build with gcc 15.
Signed-off-by: Vincent Stehlé <vincent.stehle@laposte.net>
---
Hi,
I could verify that this still compiles fine with gcc 14 and 13.
Best regards,
Vincent.
ipl/pdc_misc.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/ipl/pdc_misc.c b/ipl/pdc_misc.c
index f516bd8..ab2191a 100644
--- a/ipl/pdc_misc.c
+++ b/ipl/pdc_misc.c
@@ -95,7 +95,10 @@ firmware_call(unsigned long long fn, ...)
}
else
{
- typedef int (*firmware_entry)();
+ typedef int (*firmware_entry)(unsigned long, unsigned long,
+ unsigned long, unsigned long, unsigned long, unsigned long,
+ unsigned long, unsigned long, unsigned long, unsigned long,
+ unsigned long, unsigned long, unsigned long, unsigned long);
unsigned long arg0, arg1, arg2, arg3, arg4, arg5, arg6, arg7, arg8,
arg9, arg10, arg11, arg12, arg13;
--
2.47.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ipl: adjust firmware entry type
2025-08-30 15:22 [PATCH] ipl: adjust firmware entry type Vincent Stehlé
@ 2025-08-30 15:25 ` Vincent Stehlé
0 siblings, 0 replies; 2+ messages in thread
From: Vincent Stehlé @ 2025-08-30 15:25 UTC (permalink / raw)
To: Vincent Stehlé; +Cc: linux-parisc, Helge Deller
I forgot to mention: this patch is for the palo bootloader.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-08-30 15:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-30 15:22 [PATCH] ipl: adjust firmware entry type Vincent Stehlé
2025-08-30 15:25 ` Vincent Stehlé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).