From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f175.google.com (mail-qt1-f175.google.com [209.85.160.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C1A4543DA31 for ; Mon, 29 Jun 2026 17:11:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782753088; cv=none; b=YAAt0ocaSMG9zYVN1JY8FEbppWXCsDPxUQBi1H+eBFv6x7mx/t0br6cMVS4rZN7xWsrJB9ITijGirS0bHrwI8P70qwvYBYCZV5pUT/j1E/625SSUJFpVYn+l13z2Mh8fHfMQikcsYjDxZZj/PvvJWUvzB2Zzk0A4N+2iqlOZnU8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782753088; c=relaxed/simple; bh=NzS+Cir/zCg/P5bHO1uwaI39NGJ0soZPEUZf3jpz04g=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JdRFLzCxZEl57DFuBAr1qncj/tEeBg4xEda5r6yvxsMJSzRGwhl+HUL9pwpOAv9Og8J/GDdFvZKZEeXwcK9BmpbW4P5B97gGsdr0I604K0ZpDscaFsqbA08C6ek7nO4+wTYbIvEHbSPDjmSI302+PQQnkPpFuURO9yqYEEqlF10= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=kRN6V9UH; arc=none smtp.client-ip=209.85.160.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="kRN6V9UH" Received: by mail-qt1-f175.google.com with SMTP id d75a77b69052e-51c04bf4711so12713031cf.2 for ; Mon, 29 Jun 2026 10:11:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1782753086; x=1783357886; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=C6+KY00whvPT5nv3+mPk4rrEbELgRer0MfbyQfoaO+U=; b=kRN6V9UHAwpM/B7ZQj92hJHopNqlsQzIOmXqJMvTamcPlxklFV0LvQy3QWNM1QP7Cg GH/B6j4NR8EjGWtJ7y0rtEMD72lM/Ol3O+kcCCLmBYgCUwpCnz6M1Vza/HDIPhr6Ho4g FS0AYtSrLnOR62Sl4+Fp9dyFooraqcXxfpe7UwDAsCQUNyQjDBIydzrxtTHhX8muDIPl 2ceKAx0MDUrzb4lVg5ptX3iKHFRgKue5Hj9zJmMze7I9Iurb8+M5gdBoW3w835DtCSQO 1zERXqGaVZ5i0l6HUbCKx7j/x3Ayfyuf747TFFD7HbgApsGBKGgEEuj3GQDHNhvWC4aK pBhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782753086; x=1783357886; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=C6+KY00whvPT5nv3+mPk4rrEbELgRer0MfbyQfoaO+U=; b=dsQ6mssgcG+A4Nd9s5jZYweOAlXHWtt9rqapw3qRc8qM/Mvky1+HGOqYD4U3PpWRXE noQFcRoJOAo71flsScUYgeq4cUzwOhFU1/WDUxLuTakoXa60BBVcFg3xJOlMrkRwvxUU /4nMUY3E7NHOlNIoHeenNwRizqHFxQ8jDrdX1xiE7vKyEmC5mjLFAdNS2zL05UmR7UPp KZOun1fszAVPLEy0MSZ4zSRq1q69gOPVJXhUFOgMNESMFKsS3B1F8s9lD6/tX9DdP3cc TOLJ/GCNUSiqCltmzZylACc27lw/4P+ZP7Ezp4h+++HKBLPVsjkbssBhoMnkH8qf8Gcz alvw== X-Forwarded-Encrypted: i=1; AFNElJ+exY/WKXaLG3Vg1MlHIVHAIFj5SPQmzQlVZsPDMWtRhx55PErETTrNdPNu7TuFAnr9bkx5UjswUA/Ezd4=@vger.kernel.org X-Gm-Message-State: AOJu0YxxzmmoBatMbXG9cAO9VyEC/j/z/IR/D9uAXVol6gki51gL6PDb 6J9BjviX9dV0yYcZU5z+bWdN9fLpgsJcM0Y/jM2CA87Xfi/Xd6RI88DlTTGhwT1grjo= X-Gm-Gg: AfdE7ckT+NmJaxAuDWrhVwpd2AIjDLhNDSJver6nmwDO6EMRFfnVJcgGGegu9MTqx6F 15ivYq3Yl9GGKZSQ+MK4PR3yAC3Hr1H3MYEp5zpsk1uK9JwZblSOG0MLlpkYFhYH4vbPJ+cFeUE S6bJ9zELJG0fbo0s+PTGBsj4pXyV7jZszdnVdLPXoLQelVR1boSRYZWQuYz0+kr7eOWfL1JifUw 81QhzUyzv0osy0nNmv1Hip7ZYVCog1bbb3J6Lo1S7UpN+8SIJzsUOJI15sSa0+0cPOdHJqJ3S40 irX6N/onYAmvkUGVs1WPIVIT4NQu8E+phJswBrTXQaIsBNyvztuIbn8aJreqqqwKoa7KxlhyTl8 oKCXidO1JTpVoxTnqAA/FqWXWiZ6NtUr82GD3m0xaP7eYHB97tfeL+/ZZae8myOkSZ8N6RhxWAK S6uQlranJxMPCUcgjbOwRtuwBwJ6RcWjh2D7vKfPOBg7JayjjonQTN4CpuaJs/6fFgMSdkJcpl+ xRVDwM= X-Received: by 2002:a05:622a:420b:b0:517:58f6:29c3 with SMTP id d75a77b69052e-51c107f633bmr2561751cf.32.1782753085667; Mon, 29 Jun 2026 10:11:25 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F (pool-173-79-60-52.washdc.fios.verizon.net. [173.79.60.52]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-51c1080d4dcsm934601cf.5.2026.06.29.10.11.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jun 2026 10:11:25 -0700 (PDT) Date: Mon, 29 Jun 2026 13:11:19 -0400 From: Gregory Price To: Lorenzo Stoakes Cc: Andrew Morton , Russell King , Dinh Nguyen , Simon Schuster , "James E . J . Bottomley" , Helge Deller , Jarkko Sakkinen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Ian Abbott , H Hartley Sweeten , Lucas Stach , David Airlie , Simona Vetter , Patrik Jakobsson , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Tomi Valkeinen , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Christian Koenig , Huang Rui , Ankit Agrawal , Alex Williamson , Alexander Viro , Christian Brauner , Dan Williams , Muchun Song , Oscar Salvador , David Hildenbrand , Suren Baghdasaryan , "Liam R . Howlett" , Matthew Wilcox , Marek Szyprowski , Peter Zijlstra , Arnaldo Carvalho de Melo , Namhyung Kim , Masami Hiramatsu , Oleg Nesterov , Steven Rostedt , SeongJae Park , Miaohe Lin , Hugh Dickins , Mike Rapoport , Kees Cook , Paolo Bonzini , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-parisc@vger.kernel.org, linux-sgx@vger.kernel.org, etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-tegra@vger.kernel.org, kvm@vger.kernel.org, linux-fsdevel@vger.kernel.org, nvdimm@lists.linux.dev, linux-mm@kvack.org, iommu@lists.linux.dev, linux-perf-users@vger.kernel.org, linux-trace-kernel@vger.kernel.org, kasan-dev@googlegroups.com, damon@lists.linux.dev, Pedro Falcato , Rik van Riel , Harry Yoo , Jann Horn Subject: Re: [PATCH 05/30] mm/rmap: update mm/interval_tree.c comments Message-ID: References: <80d482a927b2e9862487b812e0ab48ebc1289a70.1782735110.git.ljs@kernel.org> Precedence: bulk X-Mailing-List: linux-parisc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Jun 29, 2026 at 05:41:16PM +0100, Lorenzo Stoakes wrote: > On Mon, Jun 29, 2026 at 12:01:02PM -0400, Gregory Price wrote: > > On Mon, Jun 29, 2026 at 01:23:16PM +0100, Lorenzo Stoakes wrote: > > > Update the file comment to clarify that both file-backed and anonymous > > > interval trees are provided, referencing the relevant data types for > > > clarity. > > > > > > > Isn't this self-evident by nature of the function definitions? > > (one takes a vm_area_struct, the other takes an anon_vma_chain) > > Well you see you're already hitting up on issues there, they both take an > rb_root_cached and the vma_*() ones do not instantly scream 'file-backed' do > they? As VMAs are obviously used for buth anon and file-backed... > > But later patches fix this stuff :) > > And I feel it's hard visually to see where one set of definitions end and > another begins, which was really the motive for this, as trivial as it is! > Fair enough, I scanned the rest initially but trying to wrap my head around everything as i go through one by one. Generally this really screams "fix the apis" not "comment the bad ones" - but i suppose that's the whole point here. It's definitely an improvement either way. Reviewed-by: Gregory Price ~Gregory