From: Thomas Gleixner <tglx@linutronix.de>
To: James Bottomley <jbottomley@parallels.com>
Cc: Parisc List <linux-parisc@vger.kernel.org>
Subject: Re: Fix parisc compile failure after smp: Add task_struct argument to __cpu_up()
Date: Fri, 25 May 2012 14:21:07 +0200 (CEST) [thread overview]
Message-ID: <alpine.LFD.2.02.1205251420311.3231@ionos> (raw)
In-Reply-To: <1337943565.2932.24.camel@dabdike.int.hansenpartnership.com>
On Fri, 25 May 2012, James Bottomley wrote:
> commit 8239c25f47d2b318156993b15f33900a86ea5e17 added an argument to our
> __cpu_up() function, but didn't notice we have an extra definition for
> this in asm/smp.h resulting in a compile failure.
>
> Fix by removing the extraneous parisc definition of __cpu_up(). While
> we're at it, remove the duplicated definition of smp_send_reschedule().
Ooops. Sorry.
> James
>
> ---
>
> diff --git a/arch/parisc/include/asm/smp.h b/arch/parisc/include/asm/smp.h
> index e8f8037..a5dc906 100644
> --- a/arch/parisc/include/asm/smp.h
> +++ b/arch/parisc/include/asm/smp.h
> @@ -25,7 +25,6 @@ typedef unsigned long address_t;
> #define cpu_number_map(cpu) (cpu)
> #define cpu_logical_map(cpu) (cpu)
>
> -extern void smp_send_reschedule(int cpu);
> extern void smp_send_all_nop(void);
>
> extern void arch_send_call_function_single_ipi(int cpu);
> @@ -50,6 +49,5 @@ static inline void __cpu_die (unsigned int cpu) {
> while(1)
> ;
> }
> -extern int __cpu_up (unsigned int cpu);
>
> #endif /* __ASM_SMP_H */
>
>
prev parent reply other threads:[~2012-05-25 12:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-25 10:59 Fix parisc compile failure after smp: Add task_struct argument to __cpu_up() James Bottomley
2012-05-25 12:21 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.02.1205251420311.3231@ionos \
--to=tglx@linutronix.de \
--cc=jbottomley@parallels.com \
--cc=linux-parisc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox