From: Meelis Roos <mroos@linux.ee>
To: James Bottomley <James.Bottomley@hansenpartnership.com>
Cc: John David Anglin <dave.anglin@bell.net>, linux-parisc@vger.kernel.org
Subject: Re: parisc 4.13-git, BUG: sleeping function called from invalid context at mm/slab.h:416
Date: Sun, 30 Jul 2017 21:12:30 +0300 (EEST) [thread overview]
Message-ID: <alpine.LRH.2.20.1707302112140.27473@math.ut.ee> (raw)
In-Reply-To: <1501428648.3670.1.camel@HansenPartnership.com>
> How about this? There's no need to take the write lock when creating
> links anyway.
No effect.
>
> James
>
> ---
>
> diff --git a/drivers/parisc/pdc_stable.c b/drivers/parisc/pdc_stable.c
> index 7147aa53e9a2..d7c88b1eaf06 100644
> --- a/drivers/parisc/pdc_stable.c
> +++ b/drivers/parisc/pdc_stable.c
> @@ -331,13 +331,13 @@ pdcspath_hwpath_write(struct pdcspath_entry *entry, const char *buf, size_t coun
> /* Now, dive in. Write back to the hardware */
> pdcspath_store(entry);
>
> + write_unlock(&entry->rw_lock);
> +
> /* Update the symlink to the real device */
> sysfs_remove_link(&entry->kobj, "device");
> ret = sysfs_create_link(&entry->kobj, &entry->dev->kobj, "device");
> WARN_ON(ret);
>
> - write_unlock(&entry->rw_lock);
> -
> printk(KERN_INFO PDCS_PREFIX ": changed \"%s\" path to \"%s\"\n",
> entry->name, buf);
>
>
--
Meelis Roos (mroos@linux.ee)
next prev parent reply other threads:[~2017-07-30 18:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-29 19:09 parisc 4.13-git, BUG: sleeping function called from invalid context at mm/slab.h:416 Meelis Roos
2017-07-29 19:53 ` John David Anglin
2017-07-29 20:27 ` James Bottomley
2017-07-30 6:47 ` Meelis Roos
2017-07-30 12:27 ` John David Anglin
2017-07-30 15:30 ` James Bottomley
2017-07-30 18:12 ` Meelis Roos [this message]
2017-07-30 18:21 ` John David Anglin
2017-07-30 18:37 ` James Bottomley
2017-07-30 18:53 ` Helge Deller
2017-07-30 19:27 ` John David Anglin
2017-07-30 19:08 ` Meelis Roos
2017-08-01 7:52 ` Meelis Roos
2017-08-01 14:26 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.20.1707302112140.27473@math.ut.ee \
--to=mroos@linux.ee \
--cc=James.Bottomley@hansenpartnership.com \
--cc=dave.anglin@bell.net \
--cc=linux-parisc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox