From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f12.google.com (mail-pj2-f12.google.com [74.125.227.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8FB5D29C328 for ; Mon, 14 Sep 2026 01:24:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.140 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789349044; cv=none; b=R3IWMYQ7O5R6qJEzwgRAXy0fwCZOcPvWK2BX//HWs0YRamOhrxT2xZX9ZUEeCARQsbiLSgHF/PPvQR6TvcMgdNT8LfhDJ3OJpGfKNDMRDZ3goqdfkEATTvSTksBE1ekLeWT2UQqo6/iI15MG04drO0opVUZhxfrDitBGFOK1lDE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789349044; c=relaxed/simple; bh=jFM/DwXHjkKXAHQoUXYqUXKTlLXJhLvu/J7v6hlyZnc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=d0tTjFhZ57+QJOaIgDMd6y/Dzv2qzomHHInk7HUTh4uMqHAnRcso7y1UhxUOCit1ztScAkbpEZuk1NpoGnHtUIiLy4wtl/Rp8//XilkNXJuVgAPQy1LwEPLjefhteJnfJNm3RAtKmLmUUcQzKsDeAq5AfKSNuh0u1tTp5mPeqac= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=I0BWg6mJ; arc=none smtp.client-ip=74.125.227.140 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="I0BWg6mJ" Received: by mail-pj2-f12.google.com with SMTP id d9443c01a7336-2d8fe517774so19817935ad.0 for ; Sun, 13 Sep 2026 18:24:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789349041; x=1789953841; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=hnFkbktqoVqh7KvfNL372TtJBe46jI4r1nKfWafzrAI=; b=I0BWg6mJKTHFG3nGKLsrqQ8/73BBIFltQA8KnZ2K1B8YSyy5hpzd8CA0pb5kiL5gyD fRSLfKuJfTGIu/Eb5OPAqFMaAYPQ5nryUdskcZTfMyn/0/2so48vXFc8+0czd2gfyTRm FA9IFsOL5C11iBIpxxvAA9DWv0Dw+uv75OyGXHaVTPA9BJxiIebM3rswBXFB5V7O+TkP m6d3cTX+chg2io9KG3kkGe70QW2iRCmwe/0kWObYe29sRK6aoxn6d6DdHxjgzlxICGYi YU6N/AE2H9e5S10Asypw/9SZ0ZfGJmQhN9AXwyUXRnFJ8sD45cGvktgnI7kz2Lx07zab QJSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789349041; x=1789953841; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=hnFkbktqoVqh7KvfNL372TtJBe46jI4r1nKfWafzrAI=; b=VE1iJosXBj+L0xql5KuXGrZZstspKXbOz52kfJKXm5yWhBC4vNDkezbgDDVO+LbGq5 jRqwl+T84yRzQfJzl/3PnOs1APq6YMihWMQ0j8PQC9N63m72wPxt5uMBN6ZFG2GgpA39 dUOfu60kpA4zyhGpFyBO34QGDrjfK1XjDE7Y72Oqv0Vbv+MH2M0KvULV/zjqXh/w6kSq IInx0BdJM+zizLwfWuIPMa3GplrLjs9ufBEwjZroQLlyzzfFLA2eEOLM2curmfrt+TYM u3txREljIbYh+lN9rSofwt6t5iCv5RxrWeDU369O4IHU5EbQAN135Iwce6NlPMvmvz8A 2fmA== X-Forwarded-Encrypted: i=1; AKwUvBwaPIsYkE4S0kcBybDqNixK40XIxTTEksPJ4i64KcldXf7YuRxgxPdy0tnfmjvUfLW1tiJhT7nkSFjX65k=@vger.kernel.org X-Gm-Message-State: AFuF++ntRd8SqNkhNvJGirW3tCeyA5UpsJ4gA3JGOcg0VBhnU88O8c+E 9DPZ/ir6oWGbiCZl66Yp3kmVD1zeCvkNuSB7luLBlpFJj2FCCUjKZ2Ap X-Gm-Gg: AYBFou2x/SBC3S2rJEvo6NEN39Jc1HYQgmd8aMav0iyTNohVQWNTZVBx+ksoMwkcHt3 xbN1o61E1UqfVV+RwmBVh1Opnxxr9i1ev77I+Gh9hDGCGOJdvsUusi2TxpYzeLfhCnW4ezQktnG i5nSu8tNsQQZF2Z7wfjnzhIkeWtlq/smV5VyZUjQPC9N4AhrVO+KxO4rCzCqODL1dvVXcosmxf/ HTs68fqR7yEKPZG7cxjURMrx4k3bI7QwS9bPctReFTOmDjSa84l8ReSvlc5h4dcnw6KH73J3Rdc xpMzfcje+gXbR/0NpFCYRtcD5JfhIeh9DzOXMH5FnMRcdu8Hk3rWHYmXhvEhX9xyEdy4giNwxgL IjUR25MHeBr34jufBmtudNPvWJlj6DCdGgqBGFseiBkLf9NkvbgYNM7UMRg413gH6Y/Pto8kJ2n IBliZXdxzG4QFycnICY5Jj3WTMDPwHYY40qjQz0mEH4rt3OMBan/Yhili3xWdw+/IooLkM+HUw+ +LdWOtJzg4Lq+NF5BghniR8g/CGd9CeIcwKa+wiGQDyVIoggVw= X-Received: by 2002:a17:90b:39cc:b0:39d:e54c:8658 with SMTP id 98e67ed59e1d1-39debf547abmr1067411a91.5.1789349040552; Sun, 13 Sep 2026 18:24:00 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:a739:376c:7eb4:ea2d]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-33ba4fb3ddasm20363582eec.30.2026.09.13.18.23.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Sep 2026 18:23:59 -0700 (PDT) Date: Sun, 13 Sep 2026 18:23:56 -0700 From: Dmitry Torokhov To: Runyu Xiao Cc: "James E . J . Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Jianhao Xu Subject: Re: [PATCH] Input: hp_sdc: shut down kicker timer on module exit Message-ID: References: <20260902154004.3595416-1-runyu.xiao@seu.edu.cn> Precedence: bulk X-Mailing-List: linux-parisc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260902154004.3595416-1-runyu.xiao@seu.edu.cn> On Wed, Sep 02, 2026 at 11:40:04PM +0800, Runyu Xiao wrote: > hp_sdc_kicker() rearms hp_sdc.kicker with mod_timer() after scheduling the > tasklet. The module exit path uses timer_delete_sync(). That waits for a > callback already running but can still leave the timer rearmed. > > A callback can therefore leave the timer pending while hp_sdc_exit() tears > down the driver, allowing timer activity to access dismantled driver state. > > Use timer_shutdown_sync() for final teardown. It waits for a running > callback and prevents rearming after module exit begins. > > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > Cc: stable@vger.kernel.org > Assisted-by: Codex:GPT-5 > Signed-off-by: Runyu Xiao Applied, thank you. -- Dmitry