From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pz2-f40.google.com (mail-pz2-f40.google.com [74.125.228.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1BFAC37CD59 for ; Mon, 28 Sep 2026 05:19:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.228.40 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790572753; cv=none; b=FCvFvHsEADU/uDRf8IK0HKhL7k5uoFrUQc4U1hsA5jGX+vp1OFBA1ikE8H899AqEus8jFH0K1vQMRXtpl+JcT5uZRGM40MWtWB2lKl+21tsvCCHr+vM7SGd2Y8l3MB2wXKdWqYFo7h39MWnCebs75+rGkPLO5vKGtlPVWVSpwb8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790572753; c=relaxed/simple; bh=If6eyZW189bAWCED7HJ77WUzjEmoh3HbC+AtCUG98As=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nsR7h4Sxhm0JjuOLnKPMjRX1PDMNt4hWnsM1n7erldWEbU899n/jJVXiALRl64xINcgJ3P+qvapmCnRMqG8X9I3NyR0wVHkJGPaOl5N+q7nulHriDe83VQhZ9JesQzkjs7qvH3gccD5fsz4gS7WPePUVepmWWQSypdTFxxp0IXI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=VLsnHB05; arc=none smtp.client-ip=74.125.228.40 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="VLsnHB05" Received: by mail-pz2-f40.google.com with SMTP id 41be03b00d2f7-cc750a1482fso1387937a12.2 for ; Sun, 27 Sep 2026 22:19:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1790572751; x=1791177551; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=aE4CNeMPjoyGqhac0qEjC0MrhT1ea2sjSdxYtuXCv0E=; b=VLsnHB057PEqj83Cxn2yIfI+0MQoBNKmIded6dZ0nn1+ILxJUjWxutQUwC+y2sPiNA aI7sKbUXLH4zAqRUFKE7Jh67iQkWCvWPsKsZ4AQZlLlrBT68v5eADSnOMWla3s139WAC f50tjpI4WgqLGRh6nrmNJNv75RsAaiuO0tq8c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790572751; x=1791177551; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=aE4CNeMPjoyGqhac0qEjC0MrhT1ea2sjSdxYtuXCv0E=; b=Kth+RKDgcG9RmpxsaNuBkuNxGaqMXkd6VkZxsW0AOifAPpTQF3YHemEuE1OMqequ2m fmuDqOgVSG7WcqrkpTfsO8mlFYN5e+VmfnONEFgXmCw2dTY267TsB1hWAAWFDmx1/bQq Ki8moKf/CfswIIdTaWDFWWBkS9uqYSp6sshekQVvLCItJ/nV653Xjqzcrmc0yr83qL6w INGQEnK7h0OXtyZS2c+5ctQXMru3+oYN2pQ+cfFMnfYjTjMS+J6qqyeut0TAdCw0wrGx Ti4rBJtEHukawatutRshGdfdf9s0Xi1aVXPrASbNXtT5dca6BYMkXO4SXUW+8ASKWDXb R/1g== X-Forwarded-Encrypted: i=1; AKwUvBziFpyAV4lYKpec1mkyMHly2mxLmE1FLGb/yosmsPfoTHx5GAuWHTaN84QCUBDtmAvvT8G7qtogZ1IuCPw=@vger.kernel.org X-Gm-Message-State: AFq9FYLfk4nPSxNUvHpE+2sSLjdA/bofoyQWWuJhjcfta27uKLUO+cGa GqzFGpWQ2ZPu1217EVlNPkXO1hZkyqVov80j0yoCWJ+rPwOpiAgu9xg/tpbDSf+7cQ== X-Gm-Gg: AYBFou3J/yhusV/TT1L2bpk93oxrW3Adh1lhRUI097dKiAntgWo40XepwUeYAP0kp1X x5h34EvlSRTl0cXjWQJcmPjaYIw4SwDb0saLY2oiouRVxUI2LcEWJKo39fecC99NprnHtWjx6HS K7aKUOvG9Zxr01onVWBK6OGUAeuhwhk8lIQLlYEyqyzPfGn/JMkurekDdw2gCoOmprWS0bslOTe nAFP0m8R3pYzpkNzloKD7ZKdZIag7pp+og1ZXVsDWXMe3fat/Rem6/5YTubbxltUDbCmveOntZK NefYP4hfk0olXTUPDTHRvyoHpwSK3NvW/dEtL/Vd9XUAbWu7YSfoBv5bnQFxh8Wpt5G1SXo01JZ SNrwF/MqUpm7qMbfR8AotIbDG+NdLl/Bdk+bC/ug+DpVHQxR9ERu1yUeuq4DVvAxUVReBJohmcH KwNAvepoGjsvwUDaU9peRBtJ6j1VFoDZ6EFyVma16k+N+8vyLIUYl1pCks45Q0bpg5u4eWlXBGq AqUkgqePnz2McPhYnmm10knvmM+pXhUtxDc9IQ= X-Received: by 2002:a17:90a:597:b0:3a0:a055:1759 with SMTP id 98e67ed59e1d1-3a0bb60e55amr5032133a91.40.1790572751469; Sun, 27 Sep 2026 22:19:11 -0700 (PDT) Received: from google.com ([2a00:79e0:2031:6:fdbe:318b:98fe:bd96]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3a0b94936ddsm18408378a91.7.2026.09.27.22.19.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Sep 2026 22:19:10 -0700 (PDT) Date: Mon, 28 Sep 2026 14:19:02 +0900 From: Sergey Senozhatsky To: Michal Wilczynski Cc: Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Russell King , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Minchan Kim , Sergey Senozhatsky , Jens Axboe , Andrew Morton , linux-kernel@vger.kernel.org, llvm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-s390@vger.kernel.org, linux-block@vger.kernel.org, Yann Collet , Nick Terrell , Gao Xiang , Chao Yu , Jaegeuk Kim , Herbert Xu , Phillip Lougher , Sungguk , Jaehoon Chung , Marek Szyprowski , linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, linux-crypto@vger.kernel.org Subject: Re: [PATCH RFC 1/9] lib/lz4: import upstream LZ4 sources verbatim Message-ID: References: <20260925-lz4-vendor-upstream-v1-0-1c7ffbe21c4b@samsung.com> <20260925-lz4-vendor-upstream-v1-1-1c7ffbe21c4b@samsung.com> Precedence: bulk X-Mailing-List: linux-parisc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260925-lz4-vendor-upstream-v1-1-1c7ffbe21c4b@samsung.com> On (26/09/25 13:27), Michal Wilczynski wrote: [..] > +int LZ4_compress_fast_extState(void* state, const char* source, char* dest, int inputSize, int maxOutputSize, int acceleration) > +{ > + LZ4_stream_t_internal* const ctx = & LZ4_initStream(state, sizeof(LZ4_stream_t)) -> internal_donotuse; > + assert(ctx != NULL); Probably in some other places as well: LZ4_initStream() can return NULL, but the code immediately derefs the pointer. The assert() check seems to be misplaced, unless I'm missing something. I suppose those need to be decoupled. First LZ4_initStream() call and NULL check, then stream->internal_donotuse.