From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 22B4A126C13 for ; Thu, 3 Oct 2024 14:46:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727966785; cv=none; b=BJs+kk5xR3f28TbRMujp1eJrToPPg5DNpd2Ha4ZH/b8eCqAWvGG6XSm1vJD+23njT92Jx4oemCZOTJjUWFQKvHTnpwWNkpACJ18cYDjFfXVV7qzzo+zVifNBbkJHZyrQSpHhSl1DZBVHSfZ8R3cOK0cAKWZb6A32yfv4GTokbB0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727966785; c=relaxed/simple; bh=fQwcGRptCa9kgB5UpZHLtjKvuJo7svABcu9q/+NvTbA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YItQwOGt6dLgD9DhD8glmGJ51YlvtiiEOmNwo6z/5/ihPudHs1AKU4ElCUQyTFL5y7/4tNgZq/4eLv6Q56JkPrK0QP2ay8LB8BYB5l+ivUo2BIvctIvrCKPj1AknASrMmltU2H52DLxk3PnGVEgMOxkUTVyQIumywhaC3hZjEso= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=RJRjkiy6; arc=none smtp.client-ip=209.85.210.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="RJRjkiy6" Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-71dd92e3718so716133b3a.3 for ; Thu, 03 Oct 2024 07:46:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1727966783; x=1728571583; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/wSFs2AZuVyV0WjazJSfQ5VVOaJNnI6A+XKfJwz8XRo=; b=RJRjkiy6wiYkDiLb0vROoiS6XPsHZCveefX15k+QH7k4hb64rCWMNgxFFp/34dlzdz 6pjmu5QYEj2nv3EjUpsCLvfOK/PCplyMiQDf/z+G2waTI1x+jeKmnTeVoxkYqjRr2aHC OQmJqgS5nzXNxVuVWqTxoGIkSiBg2pK9tAKsXAa6YUiQvqbJWROLdOtX+VoUXc1CsBEb fODBgEdBAvICBIyBzjvv4YFO6drJsVLbYuotNaoRM4d/6oSLmiOd5ZkklaGfQWBesBlv MmP6B4S2hNLqb2kaeHmgzJLasbvjRBFH8GAiYOWSmtQtDwJO1yZWvg7bD8yxBas7+VFa DeFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727966783; x=1728571583; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/wSFs2AZuVyV0WjazJSfQ5VVOaJNnI6A+XKfJwz8XRo=; b=dzzsVXJV/wkZdw0cCQVA7DKuZTYw+q3Iz2pWOFAAbzlyxlOM6SGvFWC1rP0U8b/eFM i6Ao16ZFvjeTjtlHRme1gQQBSO3zCVRgvrwkUKF3M3kH92ka/G+cdYsy57bGdWOYo4aP oNFKqsQEUWLyw4B5DBGO/wJr4tnEx47+xr8ENnpUto5MP4D83Wz+DgABoAw7zyy3biyh wT+FqcUhy7AGDNioGvLhTE2dpdrP3t+tWMKMybDRvzsJJeuKfxkhnGxvEabcLNriDr0u YcRJP1Ox07FpFTz/B/JF84GNHvaVytSAY+WavgE4coJy0TktlcA2BthtDQx6ftAclAxM 0sig== X-Forwarded-Encrypted: i=1; AJvYcCVy0sHKXPE/wOMX2UsMDXMSVPK5hGIvynN3NLFqyhBf8gWlM1U+7+asB4UObClHFd20zvenygrFIfzFNlE=@vger.kernel.org X-Gm-Message-State: AOJu0Yyw+jqD9WKoAL89mwkhgC9e83sUa6RrFQCt7MrRlJCaKmO3UIRw q3rcTM7qad/CzyujEm50xODm2+v+mq6tByJdhsKd7UScopFiaM5nwpbZAtrPqSI= X-Google-Smtp-Source: AGHT+IFqtXWr7EWblGmxV8DoVUC/E8p3CDxEuCfrxe9bestz3shboebLieEWgxOyUrrtzt2XFRL+bA== X-Received: by 2002:a05:6a00:a83:b0:710:7fd2:c91 with SMTP id d2e1a72fcca58-71dc5d6df3fmr9812888b3a.26.1727966783505; Thu, 03 Oct 2024 07:46:23 -0700 (PDT) Received: from [192.168.0.4] (174-21-81-121.tukw.qwest.net. [174.21.81.121]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71dd9defa5bsm1405345b3a.153.2024.10.03.07.46.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Oct 2024 07:46:23 -0700 (PDT) Message-ID: Date: Thu, 3 Oct 2024 07:46:20 -0700 Precedence: bulk X-Mailing-List: linux-parisc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 06/10] alpha: Align prototypes of IO memcpy/memset To: Julian Vetter , Arnd Bergmann , Russell King , Catalin Marinas , Will Deacon , Guo Ren , Huacai Chen , WANG Xuerui , Andrew Morton , Geert Uytterhoeven , Ivan Kokshaysky , Matt Turner , "James E . J . Bottomley" , Helge Deller , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , Richard Weinberger , Anton Ivanov , Johannes Berg Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-alpha@vger.kernel.org, linux-parisc@vger.kernel.org, linux-sh@vger.kernel.org, linux-um@lists.infradead.org, linux-arch@vger.kernel.org, Yann Sionneau References: <20240930132321.2785718-1-jvetter@kalrayinc.com> <20240930132321.2785718-7-jvetter@kalrayinc.com> Content-Language: en-US From: Richard Henderson In-Reply-To: <20240930132321.2785718-7-jvetter@kalrayinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 9/30/24 06:23, Julian Vetter wrote: > Align the prototypes of the memcpy_{from,to}io and memset_io functions > with the new ones from iomap_copy.c and remove function declarations, > because they are now declared in asm-generic/io.h. > > Reviewed-by: Yann Sionneau > Signed-off-by: Julian Vetter > --- > Changes for v7: > - New patch > --- > arch/alpha/include/asm/io.h | 6 ++---- > arch/alpha/kernel/io.c | 4 ++-- > 2 files changed, 4 insertions(+), 6 deletions(-) > > diff --git a/arch/alpha/include/asm/io.h b/arch/alpha/include/asm/io.h > index b191d87f89c4..db3a9f41447e 100644 > --- a/arch/alpha/include/asm/io.h > +++ b/arch/alpha/include/asm/io.h > @@ -591,13 +591,11 @@ extern inline u64 readq_relaxed(const volatile void __iomem *addr) > /* > * String version of IO memory access ops: > */ > -extern void memcpy_fromio(void *, const volatile void __iomem *, long); > -extern void memcpy_toio(volatile void __iomem *, const void *, long); > extern void _memset_c_io(volatile void __iomem *, unsigned long, long); > > -static inline void memset_io(volatile void __iomem *addr, u8 c, long len) > +static inline void memset_io(volatile void __iomem *dst, int c, size_t count) > { > - _memset_c_io(addr, 0x0101010101010101UL * c, len); > + _memset_c_io(dst, 0x0101010101010101UL * c, count); By changing c from 'u8' to 'int', you need to mask before the multiplication. r~