Linux PARISC architecture development
 help / color / mirror / Atom feed
From: Helge Deller <deller@gmx.de>
To: Thorsten Blum <thorsten.blum@linux.dev>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>
Cc: linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] parisc/serial: Use generic BASE_BAUD in asm/serial.h
Date: Tue, 4 Aug 2026 15:29:51 +0200	[thread overview]
Message-ID: <eb470716-e6df-4468-ab23-4902f26a9bac@gmx.de> (raw)
In-Reply-To: <20260804132051.104647-4-thorsten.blum@linux.dev>

Hi Thorsten,

On 8/4/26 15:20, Thorsten Blum wrote:
> Include asm-generic/serial.h and use the generic BASE_BAUD definition
> instead of redefining it.
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
>   arch/parisc/include/asm/serial.h | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)

Instead of sending 3 patches, isn't removing arch/parisc/include/asm/serial.h
and adding the patch below the better approach?

Helge

diff --git a/arch/parisc/include/asm/Kbuild b/arch/parisc/include/asm/Kbuild
index d48d158f7241..4fc315085914 100644
--- a/arch/parisc/include/asm/Kbuild
+++ b/arch/parisc/include/asm/Kbuild
@@ -6,3 +6,4 @@ generic-y += kvm_para.h
  generic-y += mcs_spinlock.h
  generic-y += ring_buffer.h
  generic-y += user.h
+generic-y += serial.h



  parent reply	other threads:[~2026-08-04 13:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-04 13:20 [PATCH 1/3] parisc/serial: Use generic BASE_BAUD in asm/serial.h Thorsten Blum
2026-08-04 13:20 ` [PATCH 2/3] parisc/serial: Add include guard to asm/serial.h Thorsten Blum
2026-08-04 13:20 ` [PATCH 3/3] parisc/serial: Add SPDX license identifier " Thorsten Blum
2026-08-04 13:29 ` Helge Deller [this message]
2026-08-04 13:37   ` [PATCH 1/3] parisc/serial: Use generic BASE_BAUD in asm/serial.h Thorsten Blum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eb470716-e6df-4468-ab23-4902f26a9bac@gmx.de \
    --to=deller@gmx.de \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-parisc@vger.kernel.org \
    --cc=thorsten.blum@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox