Re: [PATCH v2] hppa/vdso: Add wrappers for vDSO functions

[Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>]

On 21/06/24 16:26, Helge Deller wrote:
> The upcoming parisc (hppa) v6.11 Linux kernel will include vDSO
> support for gettimeofday(), clock_gettime() and clock_gettime64()
> syscalls for 32- and 64-bit userspace.
> The patch below adds the necessary glue code for glibc.
> 
> Signed-off-by: Helge Deller <deller@gmx.de>
> 
> Changes in v2:
> - add vsyscalls for 64-bit too
>  
> diff -up ./sysdeps/unix/sysv/linux/hppa/sysdep.h.org ./sysdeps/unix/sysv/linux/hppa/sysdep.h
> --- ./sysdeps/unix/sysv/linux/hppa/sysdep.h.org	2024-06-15 20:20:58.992000000 +0000
> +++ ./sysdeps/unix/sysv/linux/hppa/sysdep.h	2024-06-21 19:19:02.132000000 +0000
> @@ -468,6 +468,18 @@ L(pre_end):					ASM_LINE_SEP	\
>  #define CLOB_ARGS_1 CLOB_ARGS_2, "%r25"
>  #define CLOB_ARGS_0 CLOB_ARGS_1, "%r26"
>  
> +#define VDSO_NAME	"LINUX_6.11"
> +#define VDSO_HASH	182951793
> +
> +#ifdef __LP64__
> +# define HAVE_CLOCK_GETTIME_VSYSCALL    "__vdso_clock_gettime"
> +# define HAVE_GETTIMEOFDAY_VSYSCALL     "__vdso_gettimeofday"
> +#else
> +# define HAVE_CLOCK_GETTIME_VSYSCALL    "__vdso_clock_gettime"
> +# define HAVE_CLOCK_GETTIME64_VSYSCALL  "__vdso_clock_gettime64"
> +# define HAVE_GETTIMEOFDAY_VSYSCALL     "__vdso_gettimeofday"
> +#endif /* __LP64__ */
> +
>  #endif	/* __ASSEMBLER__ */

Not sure why you have added the gettimeofday support, currently 32 bits
it is already routed to to clock_gettime (which will use 
__vdso_clock_gettime64 anyway).  For hppa to actually use, it would
require to add a way to call it for !USE_IFUNC_GETTIMEOFDAY gettimeofday,
which I am not it really be an improvement here.