From: Helge Deller <deller@gmx.de>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: John David Anglin <dave.anglin@bell.net>, linux-parisc@vger.kernel.org
Subject: Re: the patch "Convert PDC console to an early console" breaks the^M console
Date: Thu, 20 Oct 2022 22:43:31 +0200 [thread overview]
Message-ID: <fe739cd9-509b-13ec-fe9d-810a226ae316@gmx.de> (raw)
In-Reply-To: <alpine.LRH.2.21.2210201626280.28324@file01.intranet.prod.int.rdu2.redhat.com>
On 10/20/22 22:34, Mikulas Patocka wrote:
>
>
> On Thu, 20 Oct 2022, Helge Deller wrote:
>
>> On 10/20/22 21:57, Mikulas Patocka wrote:
>>>
>>>
>>> On Thu, 20 Oct 2022, Helge Deller wrote:
>>>
>>>> On 10/20/22 20:01, Helge Deller wrote:
>>>>> On 10/20/22 15:26, Mikulas Patocka wrote:
>>>>>> On Thu, 20 Oct 2022, Helge Deller wrote:
>>>>>>
>>>>>>> Your serial ports don't seem to be detected and thus missing...?!
>>>>>>
>>>>>> It seems to be so. Does it work on your C8000? - if it does, send me
>>>>>> your
>>>>>> config and I'll find the difference.
>>>>
>>>> Works for me on c8k with serial console (parameter console=ttyS0):
>>>> config attached.
>>>
>>> Thanks. CONFIG_GSC=y fixed it for me.
>>
>> Good.
>>
>>> Maybe you should update the help text for CONFIG_GSC. It says that it is
>>> "not found in B1000, C3000, J5000, A500, L1000, N4000 and upwards" - so I
>>> turned it off when making my config.
>>
>> The help text is actually correct.
>> Your C8000 does not has a GSC bus, so why does CONFIG_GSC=n disables your
>> serial ports?
>> Needs checking..
>>
>> Helge
>
> There's drivers/tty/serial/8250/Kconfig:
> config SERIAL_8250_GSC
> tristate
> depends on SERIAL_8250 && GSC
> default SERIAL_8250
>
> drivers/tty/serial/8250/Makefile:
> obj-$(CONFIG_SERIAL_8250_GSC) += 8250_gsc.o
>
> drivers/tty/serial/8250/8250_gsc.c contains this device table:
> static const struct parisc_device_id serial_tbl[] __initconst = {
> { HPHW_FIO, HVERSION_REV_ANY_ID, HVERSION_ANY_ID, 0x00075 },
> { HPHW_FIO, HVERSION_REV_ANY_ID, HVERSION_ANY_ID, 0x0008c },
> { HPHW_FIO, HVERSION_REV_ANY_ID, HVERSION_ANY_ID, 0x0008d },
> { HPHW_FIO, HVERSION_REV_ANY_ID, HVERSION_ANY_ID, 0x000ad }, <--- this matches the serial port on C8000
> { 0 }
> };
>
> So, perhaps it should depend on CONFIG_PARISC instead of CONFIG_GSC.
Right, I just came to the same conclusion.
Do you want to post a patch here on the list?
Helge
next prev parent reply other threads:[~2022-10-20 20:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1MhlGq-1pGSQJ2Koq-00dm3N@mail.gmx.net>
2022-10-20 13:26 ` the patch "Convert PDC console to an early console" breaks the^M console Mikulas Patocka
2022-10-20 18:01 ` Helge Deller
[not found] ` <4011ff49-294a-aa08-e087-d60995649e00@gmx.de>
2022-10-20 19:57 ` Mikulas Patocka
2022-10-20 20:22 ` Helge Deller
2022-10-20 20:34 ` Mikulas Patocka
2022-10-20 20:43 ` Helge Deller [this message]
2022-10-20 21:08 ` Mikulas Patocka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe739cd9-509b-13ec-fe9d-810a226ae316@gmx.de \
--to=deller@gmx.de \
--cc=dave.anglin@bell.net \
--cc=linux-parisc@vger.kernel.org \
--cc=mpatocka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox