From: "Arnd Bergmann" <arnd@arndb.de>
To: "Sebastian Ott" <sebott@redhat.com>, "Tariq Toukan" <tariqt@nvidia.com>
Cc: "Catalin Marinas" <catalin.marinas@arm.com>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
"Saeed Mahameed" <saeedm@nvidia.com>,
"Leon Romanovsky" <leon@kernel.org>,
"Mark Bloch" <mbloch@nvidia.com>, Netdev <netdev@vger.kernel.org>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
"Gal Pressman" <gal@nvidia.com>,
"Leon Romanovsky" <leonro@nvidia.com>,
"Jason Gunthorpe" <jgg@nvidia.com>,
"Michael Guralnik" <michaelgur@nvidia.com>,
"Moshe Shemesh" <moshe@nvidia.com>,
"Will Deacon" <will@kernel.org>,
"Alexander Gordeev" <agordeev@linux.ibm.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Christian Borntraeger" <borntraeger@linux.ibm.com>,
"Borislav Petkov" <bp@alien8.de>,
"Dave Hansen" <dave.hansen@linux.intel.com>,
"Gerald Schaefer" <gerald.schaefer@linux.ibm.com>,
"Vasily Gorbik" <gor@linux.ibm.com>,
"Heiko Carstens" <hca@linux.ibm.com>,
"H. Peter Anvin" <hpa@zytor.com>,
"Justin Stitt" <justinstitt@google.com>,
linux-s390@vger.kernel.org, llvm@lists.linux.dev,
"Ingo Molnar" <mingo@redhat.com>,
"Bill Wendling" <morbo@google.com>,
"Nathan Chancellor" <nathan@kernel.org>,
"Nick Desaulniers" <ndesaulniers@google.com>,
"Salil Mehta" <salil.mehta@huawei.com>,
"Sven Schnelle" <svens@linux.ibm.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
x86@kernel.org, "Yisen Zhuang" <yisen.zhuang@huawei.com>,
"Leon Romanovsky" <leonro@mellanox.com>,
Linux-Arch <linux-arch@vger.kernel.org>,
linux-arm-kernel@lists.infradead.org,
"Mark Rutland" <mark.rutland@arm.com>,
"Michael Guralnik" <michaelgur@mellanox.com>,
patches@lists.linux.dev,
"Niklas Schnelle" <schnelle@linux.ibm.com>,
"Jijie Shao" <shaojijie@huawei.com>,
"Simon Horman" <horms@kernel.org>,
"Patrisious Haddad" <phaddad@nvidia.com>
Subject: Re: [PATCH net-next V6] net/mlx5: Improve write-combining test reliability for ARM64 Grace CPUs
Date: Mon, 06 Oct 2025 15:59:33 +0200 [thread overview]
Message-ID: <0097472c-10fd-42b4-8430-c65f958b0c7d@app.fastmail.com> (raw)
In-Reply-To: <e77083c4-82ac-0c95-1cf1-5a13f15e7c58@redhat.com>
On Mon, Oct 6, 2025, at 15:57, Sebastian Ott wrote:
> On Mon, 29 Sep 2025, Tariq Toukan wrote:
>> +static void mlx5_iowrite64_copy(struct mlx5_wc_sq *sq, __be32 mmio_wqe[16],
>> + size_t mmio_wqe_size, unsigned int offset)
>> +{
>> +#if IS_ENABLED(CONFIG_KERNEL_MODE_NEON) && IS_ENABLED(CONFIG_ARM64)
>> + if (cpu_has_neon()) {
>> + kernel_neon_begin();
>> + asm volatile
>> + (".arch_extension simd;\n\t"
>> + "ld1 {v0.16b, v1.16b, v2.16b, v3.16b}, [%0]\n\t"
>> + "st1 {v0.16b, v1.16b, v2.16b, v3.16b}, [%1]"
>> + :
>> + : "r"(mmio_wqe), "r"(sq->bfreg.map + offset)
>> + : "memory", "v0", "v1", "v2", "v3");
>> + kernel_neon_end();
>> + return;
>> + }
>> +#endif
>
> This one breaks the build for me:
> /tmp/cc2vw3CJ.s: Assembler messages:
> /tmp/cc2vw3CJ.s:391: Error: unknown architectural extension `simd;'
>
> Removing the extra ";" after simd seems to fix it.
I sent that fixup earlier today:
https://lore.kernel.org/all/20251006115640.497169-1-arnd@kernel.org/
Arnd
prev parent reply other threads:[~2025-10-06 13:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-28 21:08 [PATCH net-next V6] net/mlx5: Improve write-combining test reliability for ARM64 Grace CPUs Tariq Toukan
2025-10-01 0:30 ` patchwork-bot+netdevbpf
2025-10-01 9:28 ` Paolo Abeni
2025-10-01 14:55 ` Jason Gunthorpe
2025-10-01 16:36 ` Nathan Chancellor
2025-10-01 16:45 ` Nathan Chancellor
2025-10-06 13:57 ` Sebastian Ott
2025-10-06 13:59 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0097472c-10fd-42b4-8430-c65f958b0c7d@app.fastmail.com \
--to=arnd@arndb.de \
--cc=agordeev@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=andrew+netdev@lunn.ch \
--cc=borntraeger@linux.ibm.com \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=gerald.schaefer@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=horms@kernel.org \
--cc=hpa@zytor.com \
--cc=jgg@nvidia.com \
--cc=justinstitt@google.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=leonro@mellanox.com \
--cc=leonro@nvidia.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mark.rutland@arm.com \
--cc=mbloch@nvidia.com \
--cc=michaelgur@mellanox.com \
--cc=michaelgur@nvidia.com \
--cc=mingo@redhat.com \
--cc=morbo@google.com \
--cc=moshe@nvidia.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=patches@lists.linux.dev \
--cc=phaddad@nvidia.com \
--cc=saeedm@nvidia.com \
--cc=salil.mehta@huawei.com \
--cc=schnelle@linux.ibm.com \
--cc=sebott@redhat.com \
--cc=shaojijie@huawei.com \
--cc=svens@linux.ibm.com \
--cc=tariqt@nvidia.com \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
--cc=x86@kernel.org \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).