From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D53AA2B741 for ; Wed, 11 Oct 2023 23:32:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="HbmZaTJo" Received: from [10.0.0.178] (c-76-135-56-23.hsd1.wa.comcast.net [76.135.56.23]) by linux.microsoft.com (Postfix) with ESMTPSA id 80D9A20B74C0; Wed, 11 Oct 2023 16:32:30 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 80D9A20B74C0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1697067151; bh=4Hm83xIHy0uJKbXFIfT/CbbMnnFeszXXVJIu6LMsrrc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=HbmZaTJobUZ3XDNnfzWrOkOnKOlVq7XoAVl3UI/c580uOL9uoPFUxcnZuVT3fewhn MXLwG6epTJtrZimHm5s+iWvkP0Fg8yDx8+vNEv6oZP9kQtXGr8o1hUn8iNFBP/u0Zl BGEIS0wv5i1LokehZ8ktTWZ9RlZuxQuFcrCkNMh4= Message-ID: <0f2df9e8-8145-4749-893c-e256820bb90f@linux.microsoft.com> Date: Wed, 11 Oct 2023 16:32:34 -0700 Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 14/15] asm-generic: hyperv: Use new Hyper-V headers conditionally. To: Alex Ionescu Cc: linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org, linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org, patches@lists.linux.dev, mikelley@microsoft.com, kys@microsoft.com, wei.liu@kernel.org, gregkh@linuxfoundation.org, haiyangz@microsoft.com, decui@microsoft.com, apais@linux.microsoft.com, Tianyu.Lan@microsoft.com, ssengar@linux.microsoft.com, mukeshrathor@microsoft.com, stanislav.kinsburskiy@gmail.com, jinankjain@linux.microsoft.com, vkuznets@redhat.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, will@kernel.org, catalin.marinas@arm.com References: <1696010501-24584-1-git-send-email-nunodasneves@linux.microsoft.com> <1696010501-24584-15-git-send-email-nunodasneves@linux.microsoft.com> <749f477a-1e7a-495e-bea1-e3abe8da7fb9@linux.microsoft.com> Content-Language: en-US From: Nuno Das Neves In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/5/2023 12:52 PM, Alex Ionescu wrote: >>> 3) Truly making hypertv-tlfs the "documented" header, and then > removing any duplication from HDK so that it remains the >>> "undocumented" header file. In this manner, one would include >>> hyperv-tlfs to use the stable ABI, and they would include HDK (which >>> would include hyperv-tlfs) to use the unstable+stable ABI. >> >> hyperv-tlfs.h is remaining the "documented" header. >> >> But, we can't make the HDK header depend on hyperv-tlfs.h, for 2 primary >> reasons: >> 1. We need to put the new HDK headers in uapi so that we can use them in >> our IOCTL interface. As a result, we can't include hyperv-tlfs.h (unless >> we put it in uapi as well). >> 2. The HDK headers not only duplicate, but also MODIFY some structures >> in hyperv-tlfs.h. e.g., The struct is in hyperv-tlfs.h, but a particular >> field or bitfield is not. > > #2 was something I was worried about. Do you know if the > standards/docs team is planning on updating the TLFS at some point > with updates on their end? At which point I'd assume you'd be OK with > patches to add them to hyperv-tlfs.h > I don't know the current plans for updating the TLFS. But yes, assuming a new TLFS doc has something that is needed in the kernel, hyperv-tlfs.h would be updated to support that. Thanks, Nuno