From: Nuno Das Neves <nunodasneves@linux.microsoft.com>
To: linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org,
x86@kernel.org, linux-arm-kernel@lists.infradead.org,
linux-arch@vger.kernel.org
Cc: patches@lists.linux.dev, mikelley@microsoft.com,
kys@microsoft.com, wei.liu@kernel.org,
gregkh@linuxfoundation.org, haiyangz@microsoft.com,
decui@microsoft.com, apais@linux.microsoft.com,
Tianyu.Lan@microsoft.com, ssengar@linux.microsoft.com,
mukeshrathor@microsoft.com, stanislav.kinsburskiy@gmail.com,
jinankjain@linux.microsoft.com, vkuznets@redhat.com,
tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
dave.hansen@linux.intel.com, hpa@zytor.com, will@kernel.org,
catalin.marinas@arm.com
Subject: [PATCH v3 04/15] asm-generic/mshyperv: Introduce hv_recommend_using_aeoi()
Date: Fri, 22 Sep 2023 11:38:24 -0700 [thread overview]
Message-ID: <1695407915-12216-5-git-send-email-nunodasneves@linux.microsoft.com> (raw)
In-Reply-To: <1695407915-12216-1-git-send-email-nunodasneves@linux.microsoft.com>
Factor out logic for determining if we should set the auto eoi flag in SINT
register.
Signed-off-by: Nuno Das Neves <nunodasneves@linux.microsoft.com>
Reviewed-by: Wei Liu <wei.liu@kernel.org>
---
drivers/hv/hv.c | 12 +-----------
include/asm-generic/mshyperv.h | 13 +++++++++++++
2 files changed, 14 insertions(+), 11 deletions(-)
diff --git a/drivers/hv/hv.c b/drivers/hv/hv.c
index 5ea104c61fa7..d7869205dcbe 100644
--- a/drivers/hv/hv.c
+++ b/drivers/hv/hv.c
@@ -315,17 +315,7 @@ void hv_synic_enable_regs(unsigned int cpu)
shared_sint.vector = vmbus_interrupt;
shared_sint.masked = false;
-
- /*
- * On architectures where Hyper-V doesn't support AEOI (e.g., ARM64),
- * it doesn't provide a recommendation flag and AEOI must be disabled.
- */
-#ifdef HV_DEPRECATING_AEOI_RECOMMENDED
- shared_sint.auto_eoi =
- !(ms_hyperv.hints & HV_DEPRECATING_AEOI_RECOMMENDED);
-#else
- shared_sint.auto_eoi = 0;
-#endif
+ shared_sint.auto_eoi = hv_recommend_using_aeoi();
hv_set_register(HV_MSR_SINT0 + VMBUS_MESSAGE_SINT,
shared_sint.as_uint64);
diff --git a/include/asm-generic/mshyperv.h b/include/asm-generic/mshyperv.h
index e16557523b6e..c9e166d73fca 100644
--- a/include/asm-generic/mshyperv.h
+++ b/include/asm-generic/mshyperv.h
@@ -82,6 +82,19 @@ extern u64 hv_do_fast_hypercall8(u16 control, u64 input8);
bool hv_isolation_type_snp(void);
bool hv_isolation_type_tdx(void);
+/*
+ * On architectures where Hyper-V doesn't support AEOI (e.g., ARM64),
+ * it doesn't provide a recommendation flag and AEOI must be disabled.
+ */
+static inline bool hv_recommend_using_aeoi(void)
+{
+#ifdef HV_DEPRECATING_AEOI_RECOMMENDED
+ return !(ms_hyperv.hints & HV_DEPRECATING_AEOI_RECOMMENDED);
+#else
+ return false;
+#endif
+}
+
/* Helper functions that provide a consistent pattern for checking Hyper-V hypercall status. */
static inline int hv_result(u64 status)
{
--
2.25.1
next prev parent reply other threads:[~2023-09-22 18:38 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-22 18:38 [PATCH v3 00/15] Introduce /dev/mshv drivers Nuno Das Neves
2023-09-22 18:38 ` [PATCH v3 01/15] hyperv-tlfs: Change shared HV_REGISTER_* defines to HV_MSR_* Nuno Das Neves
2023-09-22 18:52 ` Wei Liu
2023-09-22 18:38 ` [PATCH v3 02/15] mshyperv: Introduce hv_get_hypervisor_version function Nuno Das Neves
2023-09-22 18:53 ` Wei Liu
2023-09-22 18:38 ` [PATCH v3 03/15] mshyperv: Introduce numa_node_to_proximity_domain_info Nuno Das Neves
2023-09-22 18:38 ` Nuno Das Neves [this message]
2023-09-22 18:38 ` [PATCH v3 05/15] hyperv: Move hv_connection_id to hyperv-tlfs Nuno Das Neves
2023-09-22 18:38 ` [PATCH v3 06/15] hyperv-tlfs: Introduce hv_status_to_string and hv_status_to_errno Nuno Das Neves
2023-09-22 18:38 ` [PATCH v3 07/15] Drivers: hv: Move hv_call_deposit_pages and hv_call_create_vp to common code Nuno Das Neves
2023-09-22 18:38 ` [PATCH v3 08/15] Drivers: hv: Introduce per-cpu event ring tail Nuno Das Neves
2023-09-22 18:38 ` [PATCH v3 09/15] Drivers: hv: Introduce hv_output_arg_exists in hv_common.c Nuno Das Neves
2023-09-22 18:38 ` [PATCH v3 10/15] x86: hyperv: Add mshv_handler irq handler and setup function Nuno Das Neves
2023-09-22 18:38 ` [PATCH v3 11/15] Drivers: hv: export vmbus_isr, hv_context and hv_post_message Nuno Das Neves
2023-09-22 18:38 ` [PATCH v3 12/15] Documentation: Reserve ioctl number for mshv driver Nuno Das Neves
2023-09-22 18:48 ` Wei Liu
2023-09-22 18:38 ` [PATCH v3 13/15] uapi: hyperv: Add mshv driver headers defining hypervisor ABIs Nuno Das Neves
2023-09-22 18:38 ` [PATCH v3 14/15] asm-generic: hyperv: Use new Hyper-V headers conditionally Nuno Das Neves
2023-09-22 18:38 ` [PATCH v3 15/15] Drivers: hv: Add modules to expose /dev/mshv to VMMs running on Hyper-V Nuno Das Neves
2023-09-22 20:02 ` Wei Liu
2023-09-23 7:56 ` Greg KH
2023-09-23 20:58 ` Wei Liu
2023-09-24 4:48 ` Saurabh Singh Sengar
2023-09-23 7:58 ` Greg KH
2023-09-26 0:07 ` Nuno Das Neves
2023-09-26 4:52 ` Greg KH
2023-09-26 5:54 ` Wei Liu
2023-09-26 6:31 ` Greg KH
2023-09-26 7:00 ` Wei Liu
2023-09-26 8:03 ` Greg KH
2023-09-26 21:52 ` Nuno Das Neves
2023-09-27 6:01 ` Greg KH
2023-09-27 8:04 ` Wei Liu
2023-09-27 8:33 ` Greg KH
2023-09-28 0:17 ` Nuno Das Neves
2023-09-26 12:33 ` Saurabh Singh Sengar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1695407915-12216-5-git-send-email-nunodasneves@linux.microsoft.com \
--to=nunodasneves@linux.microsoft.com \
--cc=Tianyu.Lan@microsoft.com \
--cc=apais@linux.microsoft.com \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=dave.hansen@linux.intel.com \
--cc=decui@microsoft.com \
--cc=gregkh@linuxfoundation.org \
--cc=haiyangz@microsoft.com \
--cc=hpa@zytor.com \
--cc=jinankjain@linux.microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikelley@microsoft.com \
--cc=mingo@redhat.com \
--cc=mukeshrathor@microsoft.com \
--cc=patches@lists.linux.dev \
--cc=ssengar@linux.microsoft.com \
--cc=stanislav.kinsburskiy@gmail.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=wei.liu@kernel.org \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).