From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F3BF11C91 for ; Mon, 25 Sep 2023 15:52:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695657123; x=1727193123; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=aq3M8GDPMNoTrk7Xc3ttpQTC6f+Zw5+A0BsEIRwW4WA=; b=NATo0lAR369luzDtJXe8XvVyoDUguZZnRlyu5m1BBJ5Y59gtnhJhtyaM atg3ZOMQgki6I1RC3M0OCT2G6mDT/XA8h1AIc/Jgnh1Boxy8kFR1ccehK ndlPQz5Fhk+4fQTTLW2yC+DTdkfwwLrxoZEj3qiMn6CJLsQL0+dyacTGz EbRlY0SfQIJxI78lDlD1kLFJ1GyX4rC1FPaT9/35/BYPPmaokFCVpATwG hkvRBqguIhlnuysY4DR2gFFn8sD6U4Y6CTvqbHaqnpGEzDtelc+2IcrlA jsXgfsJCIOkXQ9nx+yp7ecJaGdw0cXGFexs0i0tiq8mHokskObwj7+GZX w==; X-IronPort-AV: E=McAfee;i="6600,9927,10843"; a="447775598" X-IronPort-AV: E=Sophos;i="6.03,175,1694761200"; d="scan'208";a="447775598" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Sep 2023 08:52:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10843"; a="1079260050" X-IronPort-AV: E=Sophos;i="6.03,175,1694761200"; d="scan'208";a="1079260050" Received: from stamengx-mobl1.ger.corp.intel.com ([10.249.32.149]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Sep 2023 08:51:58 -0700 Date: Mon, 25 Sep 2023 18:51:56 +0300 (EEST) From: =?ISO-8859-15?Q?Ilpo_J=E4rvinen?= To: Jithu Joseph cc: Hans de Goede , markgross@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, rostedt@goodmis.org, ashok.raj@intel.com, tony.luck@intel.com, LKML , platform-driver-x86@vger.kernel.org, patches@lists.linux.dev, ravi.v.shankar@intel.com, pengfei.xu@intel.com Subject: Re: [PATCH v2 8/9] platform/x86/intel/ifs: Add new error code In-Reply-To: <20230922232606.1928026-9-jithu.joseph@intel.com> Message-ID: <1a459161-4c36-813a-49a-4323d57b9b5@linux.intel.com> References: <20230913183348.1349409-1-jithu.joseph@intel.com> <20230922232606.1928026-1-jithu.joseph@intel.com> <20230922232606.1928026-9-jithu.joseph@intel.com> Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-490873389-1695657122=:2147" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-490873389-1695657122=:2147 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 8BIT On Fri, 22 Sep 2023, Jithu Joseph wrote: > Make driver aware of a newly added error code so that it can provide a > more appropriate error message. > > Signed-off-by: Jithu Joseph > Reviewed-by: Tony Luck > Tested-by: Pengfei Xu > --- > drivers/platform/x86/intel/ifs/runtest.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/platform/x86/intel/ifs/runtest.c b/drivers/platform/x86/intel/ifs/runtest.c > index 94d486e5d263..a29f7b8fa48e 100644 > --- a/drivers/platform/x86/intel/ifs/runtest.c > +++ b/drivers/platform/x86/intel/ifs/runtest.c > @@ -40,6 +40,8 @@ enum ifs_status_err_code { > IFS_UNASSIGNED_ERROR_CODE = 7, > IFS_EXCEED_NUMBER_OF_THREADS_CONCURRENT = 8, > IFS_INTERRUPTED_DURING_EXECUTION = 9, > + IFS_UNASSIGNED_ERROR_CODE_0xA = 0xA, > + IFS_CORRUPTED_CHUNK = 0xB, > }; > > static const char * const scan_test_status[] = { > @@ -55,6 +57,8 @@ static const char * const scan_test_status[] = { > [IFS_EXCEED_NUMBER_OF_THREADS_CONCURRENT] = > "Exceeded number of Logical Processors (LP) allowed to run Scan-At-Field concurrently", > [IFS_INTERRUPTED_DURING_EXECUTION] = "Interrupt occurred prior to SCAN start", > + [IFS_UNASSIGNED_ERROR_CODE_0xA] = "Unassigned error code 0xA", > + [IFS_CORRUPTED_CHUNK] = "Scan operation aborted due to corrupted image. Try reloading", > }; > > static void message_not_tested(struct device *dev, int cpu, union ifs_status status) > @@ -123,6 +127,8 @@ static bool can_restart(union ifs_status status) > case IFS_MISMATCH_ARGUMENTS_BETWEEN_THREADS: > case IFS_CORE_NOT_CAPABLE_CURRENTLY: > case IFS_UNASSIGNED_ERROR_CODE: > + case IFS_UNASSIGNED_ERROR_CODE_0xA: > + case IFS_CORRUPTED_CHUNK: > break; > } > return false; > Reviewed-by: Ilpo Järvinen -- i. --8323329-490873389-1695657122=:2147--