Re: [PATCH 6.12 000/562] 6.12.58-rc2 review

[Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>]

Hi Greg,

On 13/11/25 18:52, Greg Kroah-Hartman wrote:
> On Thu, Nov 13, 2025 at 03:48:53PM +0530, Harshit Mogalapalli wrote:
>> Hi Greg,
>>
>> On 11/11/25 06:54, Greg Kroah-Hartman wrote:
>>> This is the start of the stable review cycle for the 6.12.58 release.
>>> There are 562 patches in this series, all will be posted as a response
>>> to this one.  If anyone has any issues with these being applied, please
>>> let me know.
>>>
>>> Responses should be made by Thu, 13 Nov 2025 01:22:51 +0000.
>>> Anything received after that time might be too late.
>>
>> link.c: In function ‘is_x86_ibt_enabled’:
>> link.c:288:37: error: array type has incomplete element type ‘struct
>> kernel_config_option’
>>    288 |         struct kernel_config_option options[] = {
>>        |                                     ^~~~~~~
>> In file included from /u01/hamogala/stable_rc_testing/linux-stable-rc/tools/include/linux/kernel.h:8,
>>                   from main.h:14,
>>                   from link.c:17:
>> /u01/hamogala/stable_rc_testing/linux-stable-rc/tools/include/linux/build_bug.h:16:51:
>> error: bit-field ‘<anonymous>’ width not an integer constant
>>     16 | #define BUILD_BUG_ON_ZERO(e) ((int)(sizeof(struct { int:(-!!(e));
>> })))
>>        |                                                   ^
>> /u01/hamogala/stable_rc_testing/linux-stable-rc/tools/include/linux/compiler-gcc.h:26:33:
>> note: in expansion of macro ‘BUILD_BUG_ON_ZERO’
>>     26 | #define __must_be_array(a) BUILD_BUG_ON_ZERO(__same_type((a),
>> &(a)[0]))
>>        |                                 ^~~~~~~~~~~~~~~~~
>> /u01/hamogala/stable_rc_testing/linux-stable-rc/tools/include/linux/kernel.h:103:59:
>> note: in expansion of macro ‘__must_be_array’
>>    103 | #define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]) +
>> __must_be_array(arr))
>>        | ^~~~~~~~~~~~~~~
>> link.c:291:22: note: in expansion of macro ‘ARRAY_SIZE’
>>    291 |         char *values[ARRAY_SIZE(options)] = { };
>>        |                      ^~~~~~~~~~
>> link.c:294:13: warning: implicit declaration of function
>> ‘read_kernel_config’ [-Wimplicit-function-declaration]
>>    294 |         if (read_kernel_config(options, ARRAY_SIZE(options), values,
>> NULL))
>>        |             ^~~~~~~~~~~~~~~~~~
>> In file included from /u01/hamogala/stable_rc_testing/linux-stable-rc/tools/include/linux/kernel.h:8,
>>                   from main.h:14,
>>                   from link.c:17:
>> /u01/hamogala/stable_rc_testing/linux-stable-rc/tools/include/linux/build_bug.h:16:51:
>> error: bit-field ‘<anonymous>’ width not an integer constant
>>     16 | #define BUILD_BUG_ON_ZERO(e) ((int)(sizeof(struct { int:(-!!(e));
>> })))
>>        |                                                   ^
>> /u01/hamogala/stable_rc_testing/linux-stable-rc/tools/include/linux/compiler-gcc.h:26:33:
>> note: in expansion of macro ‘BUILD_BUG_ON_ZERO’
>>     26 | #define __must_be_array(a) BUILD_BUG_ON_ZERO(__same_type((a),
>> &(a)[0]))
>>        |                                 ^~~~~~~~~~~~~~~~~
>> /u01/hamogala/stable_rc_testing/linux-stable-rc/tools/include/linux/kernel.h:103:59:
>> note: in expansion of macro ‘__must_be_array’
>>    103 | #define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]) +
>> __must_be_array(arr))
>>        | ^~~~~~~~~~~~~~~
>> link.c:294:41: note: in expansion of macro ‘ARRAY_SIZE’
>>    294 |         if (read_kernel_config(options, ARRAY_SIZE(options), values,
>> NULL))
>>        |                                         ^~~~~~~~~~
>> link.c:291:15: warning: unused variable ‘values’ [-Wunused-variable]
>>    291 |         char *values[ARRAY_SIZE(options)] = { };
>>        |               ^~~~~~
>> link.c:288:37: warning: unused variable ‘options’ [-Wunused-variable]
>>    288 |         struct kernel_config_option options[] = {
>>        |                                     ^~~~~~~
>> make: *** [Makefile:249: link.o] Error 1
>> make: *** Waiting for unfinished jobs....
>>
>>
>> I see this with bpftool build.
>>
>> let us drop this commit ?
>>
>> commit: c8271196124a ("bpftool: Add CET-aware symbol matching for x86_64
>> architectures")
>>
> 
> Already dropped.
> 

Thanks for that!

With that:

No problems seen on x86_64 and aarch64 with our testing.

Tested-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>

Thanks,
Harshit


> thanks,
> 
> greg k-h