From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8061D10F8; Tue, 19 Jul 2022 14:32:06 +0000 (UTC) Received: from fraeml711-chm.china.huawei.com (unknown [172.18.147.201]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4LnLpP056Bz67Klm; Tue, 19 Jul 2022 22:30:21 +0800 (CST) Received: from lhreml710-chm.china.huawei.com (10.201.108.61) by fraeml711-chm.china.huawei.com (10.206.15.60) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Tue, 19 Jul 2022 16:32:03 +0200 Received: from localhost (10.81.209.49) by lhreml710-chm.china.huawei.com (10.201.108.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Tue, 19 Jul 2022 15:32:02 +0100 Date: Tue, 19 Jul 2022 15:32:01 +0100 From: Jonathan Cameron To: Dan Williams CC: , , , , , "Ben Widawsky" Subject: Re: [PATCH 30/46] cxl/hdm: Add sysfs attributes for interleave ways + granularity Message-ID: <20220719153201.00003099@Huawei.com> In-Reply-To: <62cb3937d12ef_3535162943b@dwillia2-xfh.notmuch> References: <165603869943.551046.3498980330327696732.stgit@dwillia2-xfh> <20220624041950.559155-5-dan.j.williams@intel.com> <20220630102637.00001d53@Huawei.com> <62cb3937d12ef_3535162943b@dwillia2-xfh.notmuch> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.29; i686-w64-mingw32) Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.81.209.49] X-ClientProxiedBy: lhreml749-chm.china.huawei.com (10.201.108.199) To lhreml710-chm.china.huawei.com (10.201.108.61) X-CFilter-Loop: Reflected > > > > > + address (N + interleave_granularity * intereleave_ways). > > > > interleave_ways > > > > Even knowing exactly what this is, I don't understand the docs so > > perhaps reword this :) > > Reworded to: > > (RO) The number of consecutive bytes of host physical address space this > decoder claims at address N before the decode rotates to the next target > in the interleave at address N + interleave_granularity (assuming N is > aligned to interleave_granularity). LGTM