* [PATCH] ptp: ocp: select CRC16 to fix build error
@ 2022-07-27 1:12 Randy Dunlap
2022-07-27 2:56 ` Jakub Kicinski
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2022-07-27 1:12 UTC (permalink / raw)
To: netdev
Cc: patches, Randy Dunlap, kernel test robot, Vadim Fedorenko,
Jonathan Lemon, Richard Cochran, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni
ptp_ocp.c uses crc16(), so it should select CRC16 to
prevent a build error:
ERROR: modpost: "crc16" [drivers/ptp/ptp_ocp.ko] undefined!
Fixes: 3c3673bde50c ("ptp: ocp: Add firmware header checks")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Vadim Fedorenko <vadfed@fb.com>
Cc: Jonathan Lemon <jonathan.lemon@gmail.com>
Cc: Richard Cochran <richardcochran@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Eric Dumazet <edumazet@google.com>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Paolo Abeni <pabeni@redhat.com>
---
drivers/ptp/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- a/drivers/ptp/Kconfig
+++ b/drivers/ptp/Kconfig
@@ -176,6 +176,7 @@ config PTP_1588_CLOCK_OCP
depends on !S390
depends on COMMON_CLK
select NET_DEVLINK
+ select CRC16
help
This driver adds support for an OpenCompute time card.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ptp: ocp: select CRC16 to fix build error
2022-07-27 1:12 [PATCH] ptp: ocp: select CRC16 to fix build error Randy Dunlap
@ 2022-07-27 2:56 ` Jakub Kicinski
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2022-07-27 2:56 UTC (permalink / raw)
To: Randy Dunlap
Cc: netdev, patches, kernel test robot, Vadim Fedorenko,
Jonathan Lemon, Richard Cochran, David S. Miller, Eric Dumazet,
Paolo Abeni
On Tue, 26 Jul 2022 18:12:13 -0700 Randy Dunlap wrote:
> ptp_ocp.c uses crc16(), so it should select CRC16 to
> prevent a build error:
>
> ERROR: modpost: "crc16" [drivers/ptp/ptp_ocp.ko] undefined!
>
> Fixes: 3c3673bde50c ("ptp: ocp: Add firmware header checks")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Vadim Fedorenko <vadfed@fb.com>
> Cc: Jonathan Lemon <jonathan.lemon@gmail.com>
Jonathan just posted this fix a few hours ago:
https://lore.kernel.org/all/20220726220604.1339972-1-jonathan.lemon@gmail.com/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-07-27 2:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-27 1:12 [PATCH] ptp: ocp: select CRC16 to fix build error Randy Dunlap
2022-07-27 2:56 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).