Archive-only list for patches
 help / color / mirror / Atom feed
From: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
To: patches@lists.linux.dev
Subject: [PATCH RESEND v1 5/9] mm/debug: Provide VM_WARN_ON_IRQS_ENABLED()
Date: Fri, 19 Aug 2022 14:24:14 -0400	[thread overview]
Message-ID: <20220819-test-endpoint-send-v1-5-dfdb252f35f4@linuxfoundation.org> (raw)
In-Reply-To: <20220819-test-endpoint-send-v1-0-dfdb252f35f4@linuxfoundation.org>

From: Thomas Gleixner <tglx@linutronix.de>

Some places in the VM code expect interrupts disabled, which is a valid
expectation on non-PREEMPT_RT kernels, but does not hold on RT kernels in
some places because the RT spinlock substitution does not disable
interrupts.

To avoid sprinkling CONFIG_PREEMPT_RT conditionals into those places,
provide VM_WARN_ON_IRQS_ENABLED() which is only enabled when VM_DEBUG=y and
PREEMPT_RT=n.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Konstantin Ryabitsev <konstantin@linuxfoundation.org>

diff --git a/include/linux/mmdebug.h b/include/linux/mmdebug.h
index 15ae78cd2853..b8728d11c949 100644
--- a/include/linux/mmdebug.h
+++ b/include/linux/mmdebug.h
@@ -94,6 +94,12 @@ void dump_mm(const struct mm_struct *mm);
 #define VM_WARN(cond, format...) BUILD_BUG_ON_INVALID(cond)
 #endif
 
+#ifdef CONFIG_DEBUG_VM_IRQSOFF
+#define VM_WARN_ON_IRQS_ENABLED() WARN_ON_ONCE(!irqs_disabled())
+#else
+#define VM_WARN_ON_IRQS_ENABLED() do { } while (0)
+#endif
+
 #ifdef CONFIG_DEBUG_VIRTUAL
 #define VIRTUAL_BUG_ON(cond) BUG_ON(cond)
 #else
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index 072e4b289c13..c96fc6820544 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -803,6 +803,9 @@ config ARCH_HAS_DEBUG_VM_PGTABLE
 	  An architecture should select this when it can successfully
 	  build and run DEBUG_VM_PGTABLE.
 
+config DEBUG_VM_IRQSOFF
+	def_bool DEBUG_VM && !PREEMPT_RT
+
 config DEBUG_VM
 	bool "Debug VM"
 	depends on DEBUG_KERNEL

-- 
b4 0.10.0-dev-c53d8


  parent reply	other threads:[~2022-08-19 18:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-19 18:24 [PATCH RESEND v1 0/9] This is a fake series to test web-endpoint-send Konstantin Ryabitsev
2022-08-19 18:24 ` [PATCH RESEND v1 1/9] slub: Make PREEMPT_RT support less convoluted Konstantin Ryabitsev
2022-08-19 18:24 ` [PATCH RESEND v1 2/9] preempt: Provide preempt_[dis|en]able_nested() Konstantin Ryabitsev
2022-08-19 18:24 ` [PATCH RESEND v1 3/9] dentry: Use preempt_[dis|en]able_nested() Konstantin Ryabitsev
2022-08-19 18:24 ` [PATCH RESEND v1 4/9] mm/vmstat: " Konstantin Ryabitsev
2022-08-19 18:24 ` Konstantin Ryabitsev [this message]
2022-08-19 18:24 ` [PATCH RESEND v1 6/9] mm/memcontrol: Replace the PREEMPT_RT conditionals Konstantin Ryabitsev
2022-08-19 18:24 ` [PATCH RESEND v1 7/9] mm/compaction: Get rid of RT ifdeffery Konstantin Ryabitsev
2022-08-19 18:24 ` [PATCH RESEND v1 8/9] u64_stats: Streamline the implementation Konstantin Ryabitsev
2022-08-19 18:24 ` [PATCH RESEND v1 9/9] u64_stat: Remove the obsolete fetch_irq() variants Konstantin Ryabitsev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220819-test-endpoint-send-v1-5-dfdb252f35f4@linuxfoundation.org \
    --to=konstantin@linuxfoundation.org \
    --cc=patches@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox