From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B5707AD23 for ; Thu, 27 Oct 2022 17:09:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 394B0C433D7; Thu, 27 Oct 2022 17:09:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666890550; bh=EbCiTuQ2kgS/ngrVR/F1f1YiMTe3QWDwlKGz5QUR6uQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JLBtJpJKkhw2ICfB0nv4qkdLQ6NK8+nD8+UIhrxplJ9DiDDBlD99y/CGcdC7z9wdx Jdb0dMMSb6KXRcpy4xpySPiBusa48kiTaiqNvqSs4k7BihwG0GoBajnCrEQ3O2hjxA y7HaibrJQMaRo9UKKIt49LBM6Fgc7ZnzajqMYZQE= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Bryan ODonoghue , Stanimir Varbanov , Mauro Carvalho Chehab Subject: [PATCH 5.4 34/53] media: venus: dec: Handle the case where find_format fails Date: Thu, 27 Oct 2022 18:56:22 +0200 Message-Id: <20221027165051.099101579@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221027165049.817124510@linuxfoundation.org> References: <20221027165049.817124510@linuxfoundation.org> User-Agent: quilt/0.67 Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Bryan O'Donoghue commit 06a2da340f762addc5935bf851d95b14d4692db2 upstream. Debugging the decoder on msm8916 I noticed the vdec probe was crashing if the fmt pointer was NULL. A similar fix from Colin Ian King found by Coverity was implemented for the encoder. Implement the same fix on the decoder. Fixes: 7472c1c69138 ("[media] media: venus: vdec: add video decoder files") Cc: stable@vger.kernel.org # v4.13+ Signed-off-by: Bryan O'Donoghue Signed-off-by: Stanimir Varbanov Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Greg Kroah-Hartman --- drivers/media/platform/qcom/venus/vdec.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/media/platform/qcom/venus/vdec.c +++ b/drivers/media/platform/qcom/venus/vdec.c @@ -157,6 +157,8 @@ vdec_try_fmt_common(struct venus_inst *i else return NULL; fmt = find_format(inst, pixmp->pixelformat, f->type); + if (!fmt) + return NULL; } pixmp->width = clamp(pixmp->width, frame_width_min(inst),