From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BCFB4629 for ; Wed, 2 Nov 2022 03:21:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C2B01C433D7; Wed, 2 Nov 2022 03:21:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1667359289; bh=9W6ezmOLbDz3LqOieQLvDR3IxuUFZE/rinyiVnz/dOw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FSYVdICOQR2N6ngC1bJbv72RH8JxjQbCMJ1KsRYYaxiJE/w2OEvuc51H53bOVXvvz avMruE8Swuj5bgtJCOKpUVhXZSZ0yFaVh2VY5Z9dkVOGX1SX/UsXQR/Cp480/QN6Y8 Acy+/Vjy6cRMWup4ReTr2tPk6gQVaft8zxXvVsjY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Thinh Nguyen , Jeff Vanhoof Subject: [PATCH 5.4 07/64] usb: dwc3: gadget: Dont set IMI for no_interrupt Date: Wed, 2 Nov 2022 03:33:33 +0100 Message-Id: <20221102022052.057727826@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221102022051.821538553@linuxfoundation.org> References: <20221102022051.821538553@linuxfoundation.org> User-Agent: quilt/0.67 Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Thinh Nguyen commit 308c316d16cbad99bb834767382baa693ac42169 upstream. The gadget driver may have a certain expectation of how the request completion flow should be from to its configuration. Make sure the controller driver respect that. That is, don't set IMI (Interrupt on Missed Isoc) when usb_request->no_interrupt is set. Also, the driver should only set IMI to the last TRB of a chain. Fixes: 72246da40f37 ("usb: Introduce DesignWare USB3 DRD Driver") Cc: stable@vger.kernel.org Signed-off-by: Thinh Nguyen Reviewed-by: Jeff Vanhoof Tested-by: Jeff Vanhoof Link: https://lore.kernel.org/r/ced336c84434571340c07994e3667a0ee284fefe.1666735451.git.Thinh.Nguyen@synopsys.com Signed-off-by: Greg Kroah-Hartman --- drivers/usb/dwc3/gadget.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/usb/dwc3/gadget.c +++ b/drivers/usb/dwc3/gadget.c @@ -981,8 +981,8 @@ static void __dwc3_prepare_one_trb(struc trb->ctrl = DWC3_TRBCTL_ISOCHRONOUS; } - /* always enable Interrupt on Missed ISOC */ - trb->ctrl |= DWC3_TRB_CTRL_ISP_IMI; + if (!no_interrupt && !chain) + trb->ctrl |= DWC3_TRB_CTRL_ISP_IMI; break; case USB_ENDPOINT_XFER_BULK: