From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C7F81C31 for ; Wed, 23 Nov 2022 09:49:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 92009C433D6; Wed, 23 Nov 2022 09:49:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1669196987; bh=53H/+7EjKmfA22wHlLzMnyLehrwUL94cYQlIrFnRQVQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=v2m7cFcMPqxs9OPmJb77qSiIQ+KFeN95Hvq9kFNaBbBEfMbzlCVrvZxEzYcYk0Exb 7gwfen3SB9XIej1hPA47nU63Nj4xFO33OvsRYMExC5WxSj4oSPvUiyZK1Ybji4Ae3l ic5FPftcOa/PcnX0Jfvju8ce22S8h7EQr11JNfLg= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Wei Yongjun , "David S. Miller" , Sasha Levin Subject: [PATCH 6.0 165/314] net: mhi: Fix memory leak in mhi_net_dellink() Date: Wed, 23 Nov 2022 09:50:10 +0100 Message-Id: <20221123084633.050869534@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221123084625.457073469@linuxfoundation.org> References: <20221123084625.457073469@linuxfoundation.org> User-Agent: quilt/0.67 Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Wei Yongjun [ Upstream commit f7c125bd79f50ec6094761090be81d02726ec6f4 ] MHI driver registers network device without setting the needs_free_netdev flag, and does NOT call free_netdev() when unregisters network device, which causes a memory leak. This patch calls free_netdev() to fix it since netdev_priv is used after unregister. Fixes: 13adac032982 ("net: mhi_net: Register wwan_ops for link creation") Signed-off-by: Wei Yongjun Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/mhi_net.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/mhi_net.c b/drivers/net/mhi_net.c index 0b1b6f650104..0b9d37979133 100644 --- a/drivers/net/mhi_net.c +++ b/drivers/net/mhi_net.c @@ -343,6 +343,8 @@ static void mhi_net_dellink(struct mhi_device *mhi_dev, struct net_device *ndev) kfree_skb(mhi_netdev->skbagg_head); + free_netdev(ndev); + dev_set_drvdata(&mhi_dev->dev, NULL); } -- 2.35.1