From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 79E1E1C31 for ; Wed, 23 Nov 2022 09:52:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D8D92C433D7; Wed, 23 Nov 2022 09:52:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1669197128; bh=3T9A7XV3dvrq5RgeaJKwXAXtgDdUaXw2bIuGUfOlCig=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QMFIpO5XrKQbaBEzrU4CZULgy669tZbQVo92Q6bNtxRrGWK2GLYG+G9upImLjvP3r /W8GY8H2u8hciAV2ydCzaFI1SpLdVDNorkWWAb4ghTLlgCm1Sehh4Jx4tJE4sxT2uT WAlcwX9hsvOMGmym8Oe3vKzfAE/M8Hk2BZU/DmFY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Jie Wang , Hao Lan , Paolo Abeni , Sasha Levin Subject: [PATCH 6.0 174/314] net: hns3: fix return value check bug of rx copybreak Date: Wed, 23 Nov 2022 09:50:19 +0100 Message-Id: <20221123084633.452115664@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221123084625.457073469@linuxfoundation.org> References: <20221123084625.457073469@linuxfoundation.org> User-Agent: quilt/0.67 Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Jie Wang [ Upstream commit 29df7c695ed67a8fa32bb7805bad8fe2a76c1f88 ] The refactoring of rx copybreak modifies the original return logic, which will make this feature unavailable. So this patch fixes the return logic of rx copybreak. Fixes: e74a726da2c4 ("net: hns3: refactor hns3_nic_reuse_page()") Fixes: 99f6b5fb5f63 ("net: hns3: use bounce buffer when rx page can not be reused") Signed-off-by: Jie Wang Signed-off-by: Hao Lan Signed-off-by: Paolo Abeni Signed-off-by: Sasha Levin --- drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c index 944f36e4d66f..44d4265f109a 100644 --- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c @@ -3736,8 +3736,8 @@ static void hns3_nic_reuse_page(struct sk_buff *skb, int i, desc_cb->reuse_flag = 1; } else if (frag_size <= ring->rx_copybreak) { ret = hns3_handle_rx_copybreak(skb, i, ring, pull_len, desc_cb); - if (ret) - goto out; + if (!ret) + return; } out: -- 2.35.1